? ? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
1 Jul 2019

We have a large block of text on the text filter tab at the top and at the bottom. Among the many problems with a large block of text like this is accessibility. Text like "see notes at the bottom" just doesn't work for assistive tech. Luckily there is a really easy solution. Using the html elements <summary> and <details>. The <details> element generates a simple no-JavaScript widget to show/hide element contents, optionally by clicking on its child <summary> element. It is fully accessible as the summary element is presented as a button to the accessibility tree.

Notes

  1. the text can be improved but its beyond the scope of this PR
  2. it is expected and desired behaviour that opening a second detail does not close the first

Testing instructions

npm i is needed "only" to check my bad scss ;) You can still test with patchtester you just wont get all the styling

Expected result

filters

avatar brianteeman brianteeman - open - 1 Jul 2019
avatar brianteeman brianteeman - change - 1 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2019
Category Administration com_config Language & Strings Layout
avatar brianteeman brianteeman - change - 1 Jul 2019
Labels Added: ? ?
82dcea9 1 Jul 2019 avatar brianteeman cs
avatar Quy Quy - test_item - 1 Jul 2019 - Tested successfully
avatar Quy
Quy - comment - 1 Jul 2019

I have tested this item successfully on 82dcea9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25394.

avatar Quy
Quy - comment - 1 Jul 2019

Instead of 4 boxes which pushes the table further down, can they all be in 1 box in Expand for notes... and still be accessible?

avatar brianteeman
brianteeman - comment - 1 Jul 2019

Yes they can be - but then we have the big wall of text again. No one ever reads big walls of text. If you want to propose better text that is not a manual then go for it - I dont have the energy for it.

avatar richard67 richard67 - test_item - 2 Jul 2019 - Tested successfully
avatar richard67
richard67 - comment - 2 Jul 2019

I have tested this item successfully on 82dcea9

> it is expected and desired behaviour that opening a second detail does not close the first

To be honest: I like this.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25394.

avatar Quy Quy - change - 2 Jul 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 2 Jul 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25394.

avatar wilsonge wilsonge - change - 4 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-04 09:57:58
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 4 Jul 2019
avatar wilsonge wilsonge - merge - 4 Jul 2019
avatar wilsonge
wilsonge - comment - 4 Jul 2019

Thanks!

avatar brianteeman
brianteeman - comment - 4 Jul 2019

Thanks

Add a Comment

Login with GitHub to post a comment