NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
30 Jun 2019

Pull Request for Issue #25364

Summary of Changes

Correcting modal-fields.es5.js to prevent trying to close a modal when we are not in a modal
Thanks @Fedik !

Note: we have not yet an es6.js. TBD by an expert.

Testing Instructions

See #25364
Run npm

After patch

All is fine. Messages are displayed

@Fedik

avatar infograf768 infograf768 - open - 30 Jun 2019
avatar infograf768 infograf768 - change - 30 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jun 2019
Category JavaScript Repository NPM Change
avatar infograf768 infograf768 - change - 30 Jun 2019
The description was changed
avatar infograf768 infograf768 - edited - 30 Jun 2019
avatar Fedik Fedik - test_item - 30 Jun 2019 - Tested successfully
avatar Fedik
Fedik - comment - 30 Jun 2019

I have tested this item successfully on 7304cfb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25371.

avatar Fedik
Fedik - comment - 30 Jun 2019

I have tested this item successfully on 7304cfb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25371.

avatar infograf768 infograf768 - change - 30 Jun 2019
Labels Added: NPM Resource Changed ?
avatar richard67 richard67 - test_item - 30 Jun 2019 - Tested successfully
avatar richard67
richard67 - comment - 30 Jun 2019

I have tested this item successfully on f12c605


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25371.

avatar infograf768 infograf768 - change - 30 Jun 2019
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 30 Jun 2019

RTC.

Thanks folks for testing.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25371.

avatar wilsonge wilsonge - change - 30 Jun 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-06-30 11:28:14
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 30 Jun 2019
avatar wilsonge wilsonge - merge - 30 Jun 2019
avatar wilsonge
wilsonge - comment - 30 Jun 2019

Thanks!

Add a Comment

Login with GitHub to post a comment