[#25354] - [4.0] Permissions accessibility
- Fixed in Code Base
- 23 Jul 2019
- Medium
- Build: 4.0-dev
- # 25354
- Diff
- brianteeman:thu3
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
As a result of the accessibility performed last night on the Permissions page it was realised that it would be best for screen reader users to know what the changed setting is. For example if they chose "inherited" they need to know that this means that "allowed - inherited" has been selected.
The super easy way to do this is to wrap the "allowed - inherited" span in the html element output. This way whenever the output is updated it is automatically announced by the screen reader.
Technically we could remove the span and put the class on the <output> element but as that would require changing the javascript as well I didn;t see the need to do that. The code in this PR works perfectly without making that change
Pull Request for Issue # .
Testing Instructions
Code review or by testing with a screen reader
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Labels |
Added:
?
?
|
||
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25354.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25354.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-23 18:05:48 |
| Closed_By | ⇒ | wilsonge |
Thanks!
thanks
I have tested this item✅ successfully on 7a34245
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25354.