? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
27 Jun 2019

Pull Request for Issue #23063 .

Summary of Changes

not so sure this is the right way

Testing Instructions

see #23063

Expected result

no more PHP Warning: Creating default object from empty value in /var/www/html/.../libraries/src/Updater/Update.php on line 299

Actual result

PHP Warning

avatar alikon alikon - open - 27 Jun 2019
avatar alikon alikon - change - 27 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jun 2019
Category Libraries
avatar zero-24
zero-24 - comment - 27 Jun 2019

How exactly can this be reproduced?

avatar SharkyKZ
SharkyKZ - comment - 27 Jun 2019
avatar SharkyKZ
SharkyKZ - comment - 27 Jun 2019

The erroneous code exists in staging so I guess it should be fixed staging? Or at least in 3.10 where warning can be reproduced?

avatar mbabker
mbabker - comment - 28 Jun 2019

This doesn't look like a fix to me. If I had to guess, the problem is there's some scenario where $this->currentUpdate hasn't been initialized yet. Proper PHPUnit test cases would help to isolate this.

avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Jun 2019
Title
[4.0] - Creating default object from empty value
[4.0] Creating default object from empty value
avatar franz-wohlkoenig franz-wohlkoenig - edited - 28 Jun 2019
avatar alikon alikon - change - 3 Aug 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-08-03 10:12:30
Closed_By alikon
Labels Added: ?
avatar alikon alikon - close - 3 Aug 2019

Add a Comment

Login with GitHub to post a comment