Feeling Lucky
?
?
[#25329] - [4.0] Plugin edit layouts
- Fixed in Code Base
- 27 Jun 2019
- Medium
- Build: 4.0-dev
- # 25329
- Diff
- brianteeman:tue4
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Render all the fields in the sidebar using the layout. There should be no visible difference or any difference in the generated code.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_plugins |
brianteeman
- comment
- 25 Jun 2019
The div with the class is not needed as the classes are already present on the fieldset
richard67
- comment
- 25 Jun 2019
Yes, I saw. Maybe you just should have put the word "generated" in bold letters in "difference in the generated code" for fast readers like me ;-)
Quy
- comment
- 26 Jun 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25329.
Quy
- comment
- 26 Jun 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25329.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 26 Jun 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25329.
Quy
- comment
- 26 Jun 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25329.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-27 10:48:35 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
wilsonge
- comment
- 27 Jun 2019
Thanks!
brianteeman
- comment
- 27 Jun 2019
Thanks
I have tested this item✅ successfully on 21b5268
No visual changes. Code shows differences but they are expected, e.g.
<div class="form-vertical form-no-margin">missing after the patch because removed with that PR. The code of the fields themselves is same as without the patch. @brianteeman maybe you should slighty modify the testing instructions.This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25329.