? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
25 Jun 2019

Pull Request for Issue joomla-framework/database#169 .

Summary of Changes

Update joomla/database from framework to get the changes from the framework database PR linked above.

The PR fixes a silly copy and paste mistake made by me when introducing MariaDB compatibility.

Thanks @SharkyKZ for finding and fixing it.

The mistake creates an error with an undefined variable which happens only when installing recent 4.0-dev with MariaDB changes on a MariaDB.

But it should be fixed soon for the CMS by updating the DB package.

Testing Instructions

Code review, or update composer.lock by the changes in this PR, do a composer install and check that the files from the database package contain the changes in joomla-framework/database#169.

Expected result

Database package up to date.

Actual result

Database package not up to date.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 25 Jun 2019
avatar richard67 richard67 - change - 25 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jun 2019
Category External Library Composer Change
avatar richard67 richard67 - change - 25 Jun 2019
Title
Update joomla database in composer.lock
[4.0] Update joomla database from framework for fixing undefined variable error when using MariaDB
avatar richard67 richard67 - edited - 25 Jun 2019
avatar richard67 richard67 - change - 25 Jun 2019
Title
[4.0] Update joomla database from framework for fixing undefined variable error when using MariaDB
[4.0] Update joomla/database package from framework for fixing undefined variable error when using MariaDB
avatar richard67 richard67 - edited - 25 Jun 2019
avatar wilsonge wilsonge - change - 25 Jun 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-06-25 22:51:45
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 25 Jun 2019
avatar wilsonge wilsonge - merge - 25 Jun 2019
avatar wilsonge
wilsonge - comment - 25 Jun 2019

Thanks!

Add a Comment

Login with GitHub to post a comment