? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
23 Jun 2019

Pull Request for Issue #25285 (comment) .

Summary of Changes

  • Add new UI text INSTL_DATABASE_INVALID_MARIADB_VERSION to installation language files.
  • When check for minimum DB version fails with mysqli or mysql driver, check if MariaDB and if so, use the right UI text for the exception.

Testing Instructions

  1. Try to install current 4.0-dev on a MariaDB of a version which does not fulfill the minimum reguirement 10.0.0. Result: See section "Actual result" below.
  2. Apply the changes of this PR and try again. Result: See section "Expected result" below.

Expected result

Error message like You need MariaDB 10.0 or higher to continue the installation. Your version is: 5.5.60-MariaDB.

Actual result

Error message like You need MySQL 10.0 or higher to continue the installation. Your version is: 5.5.60-MariaDB.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 23 Jun 2019
avatar richard67 richard67 - change - 23 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jun 2019
Category Installation Language & Strings
avatar richard67 richard67 - change - 23 Jun 2019
Labels Added: ? ?
avatar richard67 richard67 - change - 23 Jun 2019
The description was changed
avatar richard67 richard67 - edited - 23 Jun 2019
avatar richard67
richard67 - comment - 23 Jun 2019

@wilsonge Done.

avatar wilsonge wilsonge - close - 23 Jun 2019
avatar wilsonge wilsonge - merge - 23 Jun 2019
avatar wilsonge wilsonge - change - 23 Jun 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-06-23 20:39:50
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 23 Jun 2019

Thanks!

avatar richard67
richard67 - comment - 23 Jun 2019

Thanks, too.

Add a Comment

Login with GitHub to post a comment