[#25302] - [4.0] Extension-Update: Changelog-Button and empty Modal
- Closed
- 24 Jun 2019
- Medium
- Build: staging
- # 25302
Steps to reproduce the issue
Install "German Language Pack 3.9.6.1
Expected result
While there is no <changelogurl>-tag in the xml-file, for me, the Changelog-Button hasn't to appear. Instead a N/A, just like with JCE?
Actual result
The Changelog-Button appears and the modal shows an empty value.
System information (as much as possible)
J4-Alpha-10-dev
Additional comments
joomla-cms-bot
- | Labels |
Added:
?
|
||
franz-wohlkoenig
- | Labels |
Added:
J4 Issue
|
||
| Status | New | ⇒ | Discussion |
The code is only checking if there is a changelog url - it doesnt check if there is any content at that url
I have noticed this as well. There is a problem in the code somewhere as it executes the wrong query. I haven't been able to put my finger on it yet.
The code is only checking if there is a changelog url - it doesnt check if there is any content at that url
The code is wrong imho
The button should not display if no changelog url.
I tested
<?php if ($item->changelogurl != null) : ?>
instead of
<?php if ($item->changelogurl !== null) : ?>
and it will display N/A instead of the button on which one can click and get the empty modal.
or more simply
<?php if ($item->changelogurl !== '') : ?>
here works ok when there is a changelog url
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-24 10:13:17 |
| Closed_By | ⇒ | infograf768 |
Confirmed with 3.9.8.1 French pack