? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
18 Jun 2019

Meta Keywords as a meta tag has pretty much been irrelevant for 10 years (see https://yoast.com/meta-keywords/ for example)

This PR does the following

  1. Removes Site Meta Keywords from global config
  2. Removes Menu item Meta Keywords
  3. Removes per language Meta Keywords
  4. Renames the item field Meta Keywords to Keywords
  • We use this as a field with mod_related_items and com_banners

Part 2 of removing meta keywords will

  1. Move the Keyword field to a more appropriate place
  2. Check that all the keyword fields are used with mod_related_items and com_banners

Testing

Check that Meta Keyword field is removed from global config and menu items
Check that renamed Keyword field does not produce a meta key in the frontend

avatar brianteeman brianteeman - open - 18 Jun 2019
avatar brianteeman brianteeman - change - 18 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jun 2019
Category Administration com_config com_contact com_languages com_menus com_newsfeeds com_tags Language & Strings Front End com_content com_finder com_search com_users
avatar HLeithner
HLeithner - comment - 18 Jun 2019

Why do you think we should remove it? Who says it's irrelevant in all cases? Is this true for all search engines or only for google?

Our own search engine (smart search) uses the metakey for the ranking...

avatar brianteeman
brianteeman - comment - 18 Jun 2019

@HLeithner

Why do you think we should remove it? Who says it's irrelevant in all cases? Is this true for all search engines or only for google?

https://yoast.com/meta-keywords/ neither yahoo, google or bing use it

Our own search engine (smart search) uses the metakey for the ranking...

As stated in the PR

Renames the item field Meta Keywords to Keywords

avatar brianteeman brianteeman - change - 18 Jun 2019
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 18 Jun 2019

@HLeithner This was also part of the specification for the GSOC 19 SEO project https://docs.google.com/document/d/1MaOtEpp0Ma-e_d7xuXVAnGXP72ec9Ar1XrKtPQvnw4I/edit?usp=sharing

avatar HLeithner
HLeithner - comment - 18 Jun 2019

Adding the rest would be much nicer then removing something thats maybe not used ;-) but ok if george or the other maintainers are happy with it i'm too.

avatar brianteeman
brianteeman - comment - 18 Jun 2019

Adding the rest would be much nicer

I am working on some of those too

yourfreedomcoach-Mervyn-Barrett-constant-improvement

avatar simbus82
simbus82 - comment - 18 Jun 2019

Yoast is the worst source for "SEO best practice". Rubbish for wordpress newbies.

https://yandex.com/support/webmaster/controlling-robot/html.html
https://www.searchenginejournal.com/yandex-seo-guide/252885/

Meta Tag Keywords are important for SEO in Russia.
image

It is not a problem to use some plugin or some custom fields to obtain this for russian websites.
And I am the first to tell my clients not to waste time filling in that data. But only to Italian, English, French, etc. customers ... Not to Russian customers!
But Joomla needs a SEO team leader who should have a little more experience in international projects. By the way ... is there a SEO team leader in the organization?

avatar alikon
alikon - comment - 18 Jun 2019

But Joomla needs a SEO team leader who should have a little more experience in international projects.

@simbus82 i understand this like a candidature to do this work,
and imho we really need people that want to do work .....

so please submit a PR or a RFC ....whatever

p.s.
italians do it better

avatar brianteeman
brianteeman - comment - 18 Jun 2019

The reason for posting the toast link was to save time posting one link and not three. I am just submitting a pr to match the reques I have no clue on SEO.

avatar wilsonge wilsonge - change - 18 Jun 2019
The description was changed
avatar wilsonge wilsonge - edited - 18 Jun 2019
avatar wilsonge
wilsonge - comment - 18 Jun 2019

I've edited the yoast url into the PR description so anyone coming to this PR sees it first :)

avatar wilsonge
wilsonge - comment - 18 Jun 2019

@simbus82 you don't need meta keywords for yandex if you're using json ld which we will be once I finish up #25117 (yandex has been supporting that program since 2011)

avatar wilsonge
wilsonge - comment - 19 Jun 2019

We're going to need to document a b/c break to banners if/when we go with this. It seems to filter by the documents keywords. So things like the menu and global config metadata as fallbacks will be relevant there. https://github.com/joomla/joomla-cms/blob/staging/modules/mod_banners/helper.php#L35

In the mean time I'm going to try and ping some people in the Russian community to gain some extra clarification over Yandex

avatar brianteeman
brianteeman - comment - 19 Jun 2019

Re Yandex it does use keywords if this is up to date https://yandex.com/support/webmaster/controlling-robot/html.html

avatar atpatil11
atpatil11 - comment - 2 Nov 2019

Getting the following error while applying patch.

The file marked for modification does not exist: components/com_search/View/Search/HtmlView.phpscreen shot 2019-11-02 at 06 22 09


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25258.

avatar Quiviro Quiviro - test_item - 15 Nov 2019 - Tested unsuccessfully
avatar Quiviro
Quiviro - comment - 15 Nov 2019

I have tested this item 🔴 unsuccessfully on a6409db

Same error message than alpatil11.
Meta Keywords field still in global config and menu item


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25258.

avatar b2z
b2z - comment - 8 Dec 2019

Correct me if I am wrong. Updating from J3 to J4 will affect only this - it won't produce a meta key in the frontend?

A little poll by me in Russian Telegram chat about keywords states that keywords are 99.9% useless for Yandex.

avatar wilsonge
wilsonge - comment - 8 Dec 2019

Correct

avatar brianteeman
brianteeman - comment - 8 Dec 2019

So do I spend my time updating this pr to resolve the conflicts or not?

avatar brianteeman brianteeman - change - 9 Dec 2019
Labels Added: Conflicting Files
avatar joomla-cms-bot joomla-cms-bot - change - 9 Dec 2019
Category Administration com_config com_contact com_languages com_menus com_newsfeeds com_tags Language & Strings Front End com_content com_finder com_search com_users Administration com_config com_contact com_languages com_menus com_newsfeeds com_tags Language & Strings Front End com_content com_finder com_users
avatar b2z
b2z - comment - 9 Dec 2019

Here is one experience with keywords and Yandex. Quoted and translated from Russian:

For a long time I was convinced that keyword is a rudiment, about a year ago I read an article about an experiment where a person added phrases to keywords that were not on the page, and after that he received visibility through them after the time. Believe it or not - this is, as usual in our topic, everyone’s business, but I personally leave it to myself.

avatar Quy
Quy - comment - 9 Dec 2019

Unable to install your branch.

25258

avatar brianteeman
brianteeman - comment - 9 Dec 2019

I think I messed up fixing the conflicts

avatar b2z
b2z - comment - 10 Dec 2019

Just leaving a note - people keep saying that keywords for Yandex is almost useless and for those who want to keep them, can create a plugin :)

avatar sanek4life
sanek4life - comment - 4 Feb 2020

@b2z Maybe it will be a official plugin, from the main Joomla directory, as it was done for the weblinks component?

@brianteeman I mean, it can be moved as a separate plugin here: https://extensions.joomla.org/category/official-extensions/

avatar b2z
b2z - comment - 4 Feb 2020

Well, IMO keywords does not deserve such attention in 2020.

avatar brianteeman
brianteeman - comment - 4 Feb 2020

@sanek4life no - either keep it or kill it

avatar wilsonge
wilsonge - comment - 6 Feb 2020

Clearly some conflict problems but I'm happy we're not totally impeding the russian community here so let's proceed with this PR

avatar brianteeman
brianteeman - comment - 6 Feb 2020

might just make a new pr - easier than fixing the messed up merge and conflict

ccf6147 7 Feb 2020 avatar brianteeman .
avatar brianteeman brianteeman - change - 7 Feb 2020
Labels Removed: Conflicting Files
avatar brianteeman
brianteeman - comment - 7 Feb 2020

conflicts all resolved - now I understand cherry pick and force push ;)

avatar jwaisner jwaisner - test_item - 7 Feb 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 7 Feb 2020

I have tested this item ✅ successfully on 2e575aa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25258.

avatar Quy Quy - test_item - 7 Feb 2020 - Tested successfully
avatar Quy
Quy - comment - 7 Feb 2020

I have tested this item ✅ successfully on 2e575aa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25258.

avatar Quy Quy - change - 7 Feb 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 7 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25258.

avatar rdeutz rdeutz - change - 7 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-07 18:51:36
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 7 Feb 2020
avatar rdeutz rdeutz - merge - 7 Feb 2020
avatar brianteeman
brianteeman - comment - 7 Feb 2020

yay!!!!

avatar richard67
richard67 - comment - 8 Feb 2020

@brianteeman Today at 12 UTC:
j4-install-persian-language-notice

Content language isn't created with the language installation.

avatar richard67
richard67 - comment - 8 Feb 2020

New issue or PR?

avatar richard67
richard67 - comment - 8 Feb 2020

Will work on it.

avatar richard67
richard67 - comment - 8 Feb 2020

Is SQL problem ... will fix it, be patient for new PR.

avatar richard67
richard67 - comment - 8 Feb 2020

@brianteeman Shall the column keywords be removed from database table #__languages, or shall we keep it and use empty string default value? And how about other places where kewords were removed? I.e. what is the plan?

avatar brianteeman
brianteeman - comment - 8 Feb 2020

the intention was not to remove the fields in this pr as you will see that the field is still used for mod_related and com_banners

avatar richard67
richard67 - comment - 8 Feb 2020

@brianteeman Thanks for feedback. Yes, noticed that, too, and am in the middle of making PR for allowing empty values in db. am just writing the testing instructions.

avatar richard67
richard67 - comment - 8 Feb 2020

@brianteeman Could you check and test or review or both PR #27854 ?

Add a Comment

Login with GitHub to post a comment