[#25257] - Use Symfony 4 components in 4.x, dump the PHP 7.1 polyfill
- Fixed in Code Base
- 18 Jun 2019
- Medium
- Build: 4.0-dev
- # 25257
- Diff
- mbabker:sf-4
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Symfony 3.4 goes into security only support in November 2020 and EOLs in November 2021. The next LTS is Symfony 4.4 which will EOL in November 2023. Given Joomla does not have "quick" release cycles for major versions, it is better that Joomla depends on libraries that will be supported for the longest time practical, therefore this PR bumps all Symfony components to the 4.3 versions to ensure everything can be updated to 4.4 when the time comes and not tie Joomla's hands with depending on "dead" code for too long.
Also, the PHP 7.1 polyfill is not necessary if PHP 7.2 is the minimum requirement, so it is removed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Composer Change |
Shouldn't we remove "paragonie/sodium_compat": "~1.6", too? It's also a poly fill for PHP < 7.2.
No. It polyfills if ext/sodium or ext/libsodium are not installed, it's not a pure PHP 7.1 and earlier only package in the same way that paragonie/random_compat, ircmaxell/password_compat, or the symfony/polyfill-php* packages are.
if we use the namespaced syntax we should rewrite our code to use the native functions.
joomla-framework/crypt@0c0473e should be applied to Joomla\CMS\Crypt\Cipher\SodiumCipher, IMO only for 4.0. The polyfill package exposes the PHP extension APIs so there isn't a need to call the functions/methods of the polyfill package if the extensions aren't installed.
ok, thx
Sorry just bumped the session package before i saw this. can you fix the conflicts and let's get this in
| Labels |
Added:
?
?
|
||
Rebased
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-18 22:37:53 |
| Closed_By | ⇒ | wilsonge |
Thanks!
Shouldn't we remove "paragonie/sodium_compat": "~1.6", too? It's also a poly fill for PHP < 7.2.
if we use the namespaced syntax we should rewrite our code to use the native functions.