? ? Pending

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
17 Jun 2019

Pull Request for Issue #25248 .

Summary of Changes

Update typo3 phar wrapper to PHP 7+ Version. This should also fix issue #25248

avatar HLeithner HLeithner - open - 17 Jun 2019
avatar HLeithner HLeithner - change - 17 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jun 2019
Category External Library Composer Change
avatar mbabker
mbabker - comment - 17 Jun 2019

Unless there is a really good reason please don't pin to a specific version.

avatar HLeithner HLeithner - change - 17 Jun 2019
Labels Added: ? ?
avatar HLeithner
HLeithner - comment - 17 Jun 2019

@mbabker is this better?

avatar mbabker
mbabker - comment - 17 Jun 2019

Yes.

avatar wilsonge
wilsonge - comment - 17 Jun 2019

Haven’t checked what’s in the version upgrade. But the diff looks fine to me at a quick glance

avatar wojsmol
wojsmol - comment - 17 Jun 2019

@HLeithner composer.lock neds updating after #25252 was merged.

avatar HLeithner
HLeithner - comment - 17 Jun 2019

done

avatar brianteeman
brianteeman - comment - 17 Jun 2019

I have tested this item successfully on 57a8763


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25251.

avatar brianteeman
brianteeman - comment - 17 Jun 2019

I have tested this item successfully on 57a8763


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25251.

avatar brianteeman brianteeman - test_item - 17 Jun 2019 - Tested successfully
avatar wilsonge wilsonge - change - 17 Jun 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-06-17 16:26:50
Closed_By wilsonge
avatar wilsonge wilsonge - close - 17 Jun 2019
avatar wilsonge wilsonge - merge - 17 Jun 2019
avatar wilsonge
wilsonge - comment - 17 Jun 2019

Thanks!

Add a Comment

Login with GitHub to post a comment