? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
17 Jun 2019

Pull Request for Issue #25239

Summary of Changes

The "Back to Top" button is now a custom module. This allows users to disable it if need be.
The logic has also changed so that even if you have disabled the footer module but have enabled the back-top module, it will still display.

Testing Instructions

  1. Install sample data
  2. Ensure the "Back to Top" button is enabled

  1. Disable the footer module
  2. Ensure the "Back to Top" button is enabled
avatar C-Lodder C-Lodder - open - 17 Jun 2019
avatar C-Lodder C-Lodder - change - 17 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jun 2019
Category SQL Installation Front End Templates (site)
avatar C-Lodder C-Lodder - change - 17 Jun 2019
Labels Added: ?
avatar infograf768
infograf768 - comment - 17 Jun 2019

As the old (broken) code is now totally out of cassiopea index.php, would not it be sensible to make it a non-custom specific module ? I understand it would mean also a separate css not specific to cassiopea.
I am afraid otherwise that as most install will not use testing sample data, this would be a new hidden feature.

avatar C-Lodder
C-Lodder - comment - 17 Jun 2019

@infograf768 - Fair point. I really don't mind either way. Will let the powers that be decide that.

avatar infograf768
infograf768 - comment - 17 Jun 2019

Note: also see this RTC #23661

avatar C-Lodder
C-Lodder - comment - 17 Jun 2019

@infograf768 That's simply using CSS-Grid for the sidebars....not related to this

avatar C-Lodder C-Lodder - change - 2 Jul 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-07-02 14:47:52
Closed_By C-Lodder
avatar C-Lodder C-Lodder - close - 2 Jul 2019

Add a Comment

Login with GitHub to post a comment