[#25225] - Fix not converted boolean in route::_ and log warning
- Fixed in Code Base
- 8 Aug 2019
- Medium
- Build: staging
- # 25225
- Diff
- HLeithner:jroute-workaround
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25204 .
Summary of Changes
Added boolean conversion removed in pr #24089, also log a warning if wrong parameter type is used. Should be removed with J4.
Testing Instructions
use jroute::_ with $tls parameter as int and boolean (true/false)
Expected result
Now we convert it if type is Boolean.
Actual result
Boolean didn't got converted to 0 or 1.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
Just noticed this is in Route::_(). But it should be in Route::link().
For me it's only a pre Joomla 3.9 thing (and should be removed in j4) because Route::link added in this version but I'm still not sure to add it as you already stated the documentation says it's an integer.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25225.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25225.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25225.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25225.
| Labels |
Added:
?
|
||
SniperSister
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-08 10:50:58 |
| Closed_By | ⇒ | SniperSister |
@HLeithner It seems you mixed up texts for "Expected result" and "Actual result" in your description. "Expected result" should describe result with this PR applied, "Actual result" should describe result of current staging, i.e. without this PR applied.