? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
16 Jun 2019

Change the description of the extension from a tooltip to be visually displayed.

Remove the tooltip with the author url and email address as I don't see the value in displaying that information here

This improves accessibility

After

image

avatar brianteeman brianteeman - open - 16 Jun 2019
avatar brianteeman brianteeman - change - 16 Jun 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jun 2019
Category Administration com_installer
avatar brianteeman
brianteeman - comment - 16 Jun 2019

In extensions manage #25226 I didnt display the information on screen like this. If requested this pr could be updated the same way and it would be like
image

avatar Quy
Quy - comment - 16 Jun 2019

Please apply !empty to line 98.

avatar brianteeman brianteeman - change - 16 Jun 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 16 Jun 2019

Thanks @Quy all done

avatar Quy
Quy - comment - 16 Jun 2019

I have tested this item successfully on 2be0eb5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25224.

avatar Quy Quy - test_item - 16 Jun 2019 - Tested successfully
avatar tonypartridge
tonypartridge - comment - 13 Jul 2019

I have tested this item successfully on a927379

Great improvement


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25224.

avatar tonypartridge tonypartridge - test_item - 13 Jul 2019 - Tested successfully
avatar Quy Quy - change - 13 Jul 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 13 Jul 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25224.

avatar infograf768 infograf768 - change - 13 Jul 2019
Labels Added: ?
avatar wilsonge
wilsonge - comment - 13 Jul 2019

Let's see how this goes. I'm happy with displaying on screen if we can - but I have a feeling for some extensions with longer descriptions we might find it necessary to move to tooltips to be honest

avatar wilsonge wilsonge - change - 13 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-13 19:18:35
Closed_By wilsonge
avatar wilsonge wilsonge - close - 13 Jul 2019
avatar wilsonge wilsonge - merge - 13 Jul 2019
avatar wilsonge
wilsonge - comment - 13 Jul 2019

Thanks!

avatar tonypartridge
tonypartridge - comment - 13 Jul 2019

That’s a good point. We should probably limit with a load more type toggle
?

On Sat, 13 Jul 2019 at 20:18, George Wilson notifications@github.com
wrote:

Thanks!


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/joomla/joomla-cms/pull/25224?email_source=notifications&email_token=AAKWBFSMYJAH42MUNGP2Q4DP7ITBTA5CNFSM4HYQ2KKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ3XZLY#issuecomment-511147183,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKWBFU5BLVTKUAHGIJRANDP7ITBTANCNFSM4HYQ2KKA
.

avatar brianteeman
brianteeman - comment - 13 Jul 2019

Thanks

Add a Comment

Login with GitHub to post a comment