Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#25219] - 3.9.4 Merge

? ? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
16 Jun 2019

Merges all of 3.9.4 in

Merge with a merge commit. Don't squash or rebase.

avatar wilsonge wilsonge - change - 16 Jun 2019
Status New ⇒ Pending
avatar wilsonge wilsonge - open - 16 Jun 2019
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jun 2019
Category ⇒ Administration SQL com_admin com_cache com_categories com_config com_fields com_modules com_users Language & Strings Modules JavaScript Repository NPM Change Front End com_contact com_content com_tags External Library Composer Change Installation
avatar wilsonge wilsonge - change - 16 Jun 2019
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-06-16 00:56:28
Closed_By ⇒ wilsonge
Labels Added: ? ? NPM Resource Changed ?
avatar wilsonge wilsonge - close - 16 Jun 2019
avatar wilsonge wilsonge - merge - 16 Jun 2019
avatar richard67
richard67 - comment - 16 Jun 2019

@wilsonge I am missing the changes in the joomla.sql installation file for mysql in the postgresql file. Has that been forgotten? Maybe that's the reason why postgresql system tests are currently failing?

avatar wilsonge
wilsonge - comment - 16 Jun 2019

Well the PostgreSQL tasks did pass before merging this so I doubt it. All it did was change defaults of int fields from strings to ints. As far as I can tell the changes from #24058 to Postgres are already in the 4.x branch

avatar richard67
richard67 - comment - 16 Jun 2019

@wilsonge Seems you are right, sorry for annoying.

avatar wilsonge
wilsonge - comment - 16 Jun 2019

No worries! Better safe than sorry and these are the most risky PR’s :)

Add a Comment

Login with GitHub to post a comment