[#25164] - [4.0] Remove [].slice.call
- Closed
- 9 Jul 2019
- Medium
- Build: 4.0-dev
- # 25164
- Diff
- C-Lodder:array-slice
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
As stated in https://volunteers.joomla.org/departments/production/reports/1031-production-dept-meeting-may-28-2019, J4 will no longer support IE11, therefore we do not require [].slice.call(...)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
@dgrammatiko pretty sure
According to MDN https://developer.mozilla.org/en-US/docs/Web/API/NodeList
Opera for Android and Edge Mobile don't support nodeList.forEach()
@dgrammatiko It says the support it unknown. I'll give this a test tomorrow on my phone
@dgrammatiko - Tested on Edge and Opera for mobile and looping through a nodeList with forEach works fine:
https://jsfiddle.net/sjn8z0e7/1/
I'm going to submit a PR to MDN to rectify this.
| Title |
|
||||||
PR submitted: mdn/browser-compat-data#4288
and Hound issues fixed
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-09 07:43:17 |
| Closed_By | ⇒ | C-Lodder |
@C-Lodder are you sure that all evergreen browsers treat nodelists as arrays? if not you can convert the
[].slice()toArray.from()