[#25155] - [4.0] Template Style assignment: Fix toggle checkboxes
- Fixed in Code Base
- 10 Jun 2019
- Medium
- Build: 4.0-dev
- # 25155
- Diff
- infograf768:4.0_templatestyle_assignment
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Replaces #24335
Thanks @bahl24
Summary of Changes
Creates an es6.js file in the build/media_source/com_templates/
Testing Instructions
Patch.
Run npm
Edit Cassiopea template style
Template(Styles) -> Menu Assignment -> 'Toggle Selection' buttons
After patch
Note:
There may be another way to format the es6.js. Please comment before merge.
@C-Lodder
@dgrammatiko
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
@infograf768 couple things here:
- DO NOT use Global vars (eg instead of
toggleAll()you need to doJoomla.toggleAll()) - Wrap the code in an IIFE (
() => { /** your code here */ }();
eg:
/**
* @copyright Copyright (C) 2005 - 2019 Open Source Matters, Inc. All rights reserved.
* @license GNU General Public License version 2 or later; see LICENSE.txt
*/
Joomla = window.Joomla || {};
(Joomla => {
Joomla.toggleAll = () => {
const checkBoxes = [].slice.call(document.querySelectorAll('.chk-menulink'));
const value = checkBoxes[0].checked;
checkBoxes.forEach((checkBox) => {
checkBox.checked = !value;
});
};
Joomla.toggleMenutype = (a) => {
const checkBox = [].slice.call(document.getElementsByClassName(a));
const value = checkBox[0].checked;
checkBox.forEach((element) => {
element.checked = !value;
});
};
})(Joomla);
Tks, testing now
Would be nice to use hound on localhost
@infograf768 It is called Code Sniffer. See https://docs.joomla.org/Joomla_CodeSniffer
@infograf768 you can use the lint command eg npx eslint . or npm run lint:js
Bonus you can run npx eslint . --fix to autofix the CS
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25155.
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25155.
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25155.
@richard67
Should be OK now.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25155.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25155.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25155.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25155.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25155.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-10 23:01:36 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I guess I need help to solve hound :
is defined but never used no-unused-vars...