[#25147] - [4.0] Fix History Versions Modal display
- Fixed in Code Base
- 9 Jun 2019
- Medium
- Build: 4.0-dev
- # 25147
- Diff
- infograf768:4.0_history_versions_modal
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Alternative to #24369
Summary of Changes
Adding a new com_contenthistory js to prevent the modal from being hidden by back.
Loading the js ONLY when necessary (i.e. in edit views)
com_banner banner
com_banner client
com_categories category
com_contacts contact
com_content article
com_newsfeeds newsfeed
com_tags tag
com_users note
Testing Instructions
patch and npm ci
Before patch
After patch
Note
did it as es5.js Welcome help doing it as es6.js
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_contact com_content com_newsfeeds com_tags com_users JavaScript Repository NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25147.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-09 09:18:09 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
NPM Resource Changed
?
|
||
Thanks!
@infograf768 @wilsonge The name of the file should be .es6, not .es5
Everything except the function, which should use a fat arrow instead.
@infograf768 perfect
Maybe add a sanity check too, just incase the element doesn't exist:
window.addEventListener('DOMContentLoaded', () => {
const versionsModal = document.getElementById('versionsModal');
if (versionsModal) {
document.body.appendChild(versionsModal);
}
});
I have tested this item✅ successfully on af6a152
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25147.