[#25072] - Load module by id should also get the style
- Closed
- 31 May 2019
- Medium
- Build: 3.10-dev
- # 25072
- Diff
- yozmag:patch-1
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
loadmoduleid plugin keyword changed to get the module chrome style.
Pull Request for Issue # .
Summary of Changes
Changed to allow the chrome style with loadmoduleid keyword
Testing Instructions
Expected result
The chrome style should change if the plugin parameter changes or a 2nd argument is defined.
Actual result
Nothing changes always the none chrome is render.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
And isn't it a new feature that won't go into Joomla 3? I'm not sure because pr is for Joomla 3.10 branch.
If a site now uses loadmoduleid it loads the 'none' chrome'. If the parameter on the plugin is different option '-1' https://docs.joomla.org/Understanding_Output_Overrides#Module_Chrome the plugin is going to render the chrome select in the plugin parameter instead of 'none' and will impact the render of the module.
This Pr should go to 3.10 version or next 3.9... Thanks.
This Pr should go to 3.10 version or next 3.9... Thanks.
I think your pr is a new feature and not a bug fix. New features won't go into Joomla 3. You have to rebase it to Joomla 4.
But let's decide the 3.9 Release Lead @HLeithner
It's seams not to be a b/c break but a new feature, so sry please rebase of J4.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-31 14:15:34 |
| Closed_By | ⇒ | HLeithner |
I think this is a bug because the parameter is on the plugin is not taken to account when render the module like with keyword {loadposition xxxx} and {loadmodule xxxx} the styles (modChrome_style) is working. Also adding the style as parameter also works as described in joomla documentation . The load {loadmoduleid xx} was added feature on the 3.9 this doesn't make sense not to make correct only on J4, and J3. stays with the bug.
Won't this impact existing sites?