Feeling Lucky
?
?
[#25071] - [4.0] Always render module layout
- Fixed in Code Base
- 3 Jun 2019
- Medium
- Build: 4.0-dev
- # 25071
- Diff
- SharkyKZ:j4/renderModuleLayout
- Success Hound No violations found. Woof! Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Success continuous-integration/drone/pr Build is passing Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Per discussion in #20811, module layouts should always be rendered to allow overrides.
Testing Instructions
Code review should suffice.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
?
|
||
SharkyKZ
- comment
- 31 May 2019
No, that one is for mod_articles_category. This one is for other article modules.
richard67
- comment
- 31 May 2019
I see, you are right. I mixed up "...category" and "...categories".
richard67
- comment
- 31 May 2019
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25071.
richard67
- comment
- 31 May 2019
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25071.
Quy
- comment
- 31 May 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25071.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 31 May 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25071.
Quy
- comment
- 31 May 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25071.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-03 14:46:59 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 3 Jun 2019
Thanks!
Does this replace PR #24956 ?