[#25004] - [4.0] Try and fix asset table
- Fixed in Code Base
- 28 May 2019
- Medium
- Build: 4.0-dev
- # 25004
- Diff
- wilsonge:feature/fix-asset-table
- Success Hound No violations found. Woof! Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Tries to fix the asset table in j4 as i know it became broken with the addition of the new j4 extensions and the conflicts from the privacy suite in j3
For those wondering I've tried using https://gist.github.com/alexgarel/b4e4a2e3160d3b0e8559 to implement this (amending the base lft value to be 0 instead of 1 on line 64)
Paging @sanderpotjer
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin SQL Installation Postgresql |
| Labels |
Added:
?
|
||
I have tested this item
Code review including analysis of lft and rgt values with respect to parent ids and levels.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25004.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25004.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25004.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25004.
| Labels |
Added:
?
|
||
| Category | Administration com_admin SQL Installation Postgresql | ⇒ | SQL Installation Postgresql |
I realised like com_categories has no assets neither has workflows so re-removed it. Merging now.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-28 12:30:52 |
| Closed_By | ⇒ | wilsonge |
@alikon can you test this on postgres. the system tests are always failing after this. so i assume this breaks something