Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#25003] - [4.0] Fix show full description link in modules/templates

? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
24 May 2019

Summary of Changes

Fixes the changing of tab when viewing a long module description

Testing Instructions

Create a module description over 500 characters long and then click the "show full description..." link. before patch nothing happens. after patch it changes over.

Documentation Changes Required

none

avatar wilsonge wilsonge - open - 24 May 2019
avatar wilsonge wilsonge - change - 24 May 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2019
Category ⇒ Administration com_modules
avatar wilsonge wilsonge - change - 25 May 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2019
Category Administration com_modules ⇒ Administration com_modules com_templates
avatar wilsonge wilsonge - change - 25 May 2019
Title
…
Fix show full description link in modules
Fix show full description link in modules/templates
avatar wilsonge wilsonge - edited - 25 May 2019
avatar wilsonge wilsonge - change - 25 May 2019
Title
…
Fix show full description link in modules
Fix show full description link in modules/templates
avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2019
Category Administration com_modules com_templates ⇒ Administration com_modules com_plugins com_templates
avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2019
Category Administration com_modules com_templates com_plugins ⇒ Administration com_modules com_plugins com_templates SQL Installation Postgresql
avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2019
Category Administration com_modules com_templates com_plugins SQL Installation Postgresql ⇒ Administration com_modules com_plugins com_templates
avatar wilsonge wilsonge - change - 25 May 2019
Title
…
Fix show full description link in modules/templates
[4.0] Fix show full description link in modules/templates
avatar wilsonge wilsonge - edited - 25 May 2019
avatar wilsonge wilsonge - change - 25 May 2019
Title
…
Fix show full description link in modules/templates
[4.0] Fix show full description link in modules/templates
avatar richard67
richard67 - comment - 25 May 2019

I have tested this item ✅ successfully on 0abd41d

Tested as follows for menu:

  1. Create a new site menu and chose "Articles - Related", because this one has a long desciption.
  2. In the 1st tab "Module", click the "Show full description ... " link.

For template style I did not test because there is not style with a long description.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25003.

avatar richard67
richard67 - comment - 25 May 2019

I have tested this item ✅ successfully on 0abd41d

Tested as follows for menu:

  1. Create a new site menu and chose "Articles - Related", because this one has a long desciption.
  2. In the 1st tab "Module", click the "Show full description ... " link.

For template style I did not test because there is not style with a long description.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25003.

avatar richard67 richard67 - test_item - 25 May 2019 - Tested successfully
avatar richard67
richard67 - comment - 25 May 2019

But code review looks good for template styles, too.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25003.

avatar wilsonge
wilsonge - comment - 25 May 2019

templates is harder. instead of creating a long description, you actually have to create a details fieldset in the templates xml config (i promise i did test it tho :) )

avatar Quy
Quy - comment - 26 May 2019

I have tested this item ✅ successfully on 0abd41d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25003.

avatar Quy Quy - change - 26 May 2019
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 26 May 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25003.

avatar Quy Quy - test_item - 26 May 2019 - Tested successfully
avatar wilsonge wilsonge - change - 27 May 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-05-27 00:05:51
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 27 May 2019
avatar wilsonge wilsonge - merge - 27 May 2019
avatar wilsonge
wilsonge - comment - 27 May 2019

Thanks!

Add a Comment

Login with GitHub to post a comment