NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
24 May 2019

Summary of Changes

Fixes saving items in modals (e.g. creating a new item in com_menus, creating a new menu item for an article)

Testing Instructions

Open an article and try saving it. Before patch it doesn't save/validate, after patch it does (both save and save close)

This is a bug introduced by #22308 which I somehow missed at the time.

Documentation Changes Required

None

avatar wilsonge wilsonge - open - 24 May 2019
avatar wilsonge wilsonge - change - 24 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2019
Category JavaScript Repository NPM Change
avatar Quy
Quy - comment - 24 May 2019

I have tested this item successfully on b156bc3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25001.

avatar Quy
Quy - comment - 24 May 2019

I have tested this item successfully on b156bc3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25001.

avatar Quy Quy - test_item - 24 May 2019 - Tested successfully
avatar wilsonge wilsonge - change - 24 May 2019
Labels Added: NPM Resource Changed ?
avatar wilsonge wilsonge - change - 24 May 2019
The description was changed
avatar wilsonge wilsonge - edited - 24 May 2019
avatar wilsonge
wilsonge - comment - 24 May 2019

Updated patch as I discovered the save/close bug was related. So patched that instance too

avatar Quy
Quy - comment - 24 May 2019

Duplicate PR #24350.
Please read this comment. #24350 (comment)

avatar wilsonge wilsonge - close - 24 May 2019
avatar wilsonge wilsonge - merge - 24 May 2019
avatar wilsonge wilsonge - change - 24 May 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-05-24 22:46:07
Closed_By wilsonge

Add a Comment

Login with GitHub to post a comment