[#24991] - [4.0] [mod_articles_category] Add items sublayout
- Fixed in Code Base
- 9 Feb 2020
- Medium
- Build: 4.0-dev
- # 24991
- Diff
- SharkyKZ:j4/modArticlesCategoryLayout
- Success Hound No violations found. Woof! Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This adds a layout for items to remove duplicate code.
Testing Instructions
The module should work like before.
Documentation Changes Required
IDK.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
franz-wohlkoenig
- | Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Category | Modules Front End | ⇒ | Unit Tests Administration com_admin com_associations com_banners com_cache com_categories com_config com_contact |
| Labels |
Added:
?
|
||
| Category | Unit Tests Administration com_admin com_associations com_banners com_cache com_categories com_config com_contact | ⇒ | Modules Front End |
| Labels |
Removed:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24991.
@Quy Please retest.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24991.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24991.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24991.
Restarted drone.
@SharkyKZ I can't see conflicts for this PR here on GitHub, but the clone step in drone reports merge conflicts when fetching your PR into a 4.0-dev. Could you check if you can update this PR to current 4.0-dev and solve conflicts if you have some? If not I could try to have a look, ping me then.
| Labels |
Added:
?
|
||
Branch updated. Didn't see any conflicts.
Then good luck with the drone .. maybe it just has severe hickup at the moment ;-)
Clone step already passed in drone .. that's a good sign.
@richard67 What about now?
Strange. I am not getting the message you got. I get the green button to squash and merge.
Oops I have not been paying attention to Reviewers. I don’t know what the rules are so I guess we wait.
I have pinged him here and on Glip, let's see what happens.
I have tested it with success, too, and review looks good to me, so I merge.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-09 16:51:49 |
| Closed_By | ⇒ | richard67 |
Thanks.
I have tested this item✅ successfully on 84dbc89
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24991.