[#24990] - Correct archived article links in search results
- Fixed in Code Base
- 9 Jun 2019
- Medium
- Build: staging
- # 24990
- Diff
- SharkyKZ:j3/plgSearchContent
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr Build is passing Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #22395.
Summary of Changes
Corrects links to archived articles in search results.
Testing Instructions
Make sure Archived Articles option is enabled in Search - Content plugin.
Create an article. Set status to archived.
Search for the article using standard search (com_search).
Inspect link to article in search results.
Expected result
Link opens article, e.g. http://localhost/index.php/site-map/articles/9-uncategorised/67-whats-new-in-15
Actual result
Link opens archived view, e.g. http://localhost/index.php/using-joomla/extensions/components/content-component/archived-articles/2019?view=archive&month=5
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
@HerKle @beejay41 please test > https://docs.joomla.org/Testing_Joomla!_patches
I've applied the change to my test system and it now returns the expected link. Bug fixed.
My only criticism is that there are now 2 identical pieces of code ( for normal and archived articles), so if there is a need to make changes in future, the duplicate (archive) code could be overlooked. Also, only do things once.
@beejay41 please mark your test as successfully > https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results
there is no archived category iirc it's a value of the state field maybe (2)
This doesnt look correct to me. You need to also see what the archive module and archive view create
@brianteeman this is fine. Links to archive view were added as a workaround for some 1.5 issue. See https://developer.joomla.org/joomlacode-archive/issue-23764.html.
@beejay41 please mark your test as successfully > https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results
Sorry, new to this. I did as requested, and it looks to have updated the Joomla tracker, but not here. 2FA error, but I'm not using 2FA anywhere here.
@franz-wohlkoenig you will need to speak to @HLeithner about this. There has been a change in the authentication settings on github which you are hitting and need to resolve
Michael is working on this problem.
@HLeithner I assumed someone was - I just wanted to let @franz-wohlkoenig know
It's all sorted.
Comment on it, update it, do anything that triggers a webhook from GitHub to the tracker and that will sort it. It'll take me longer to log into the server and run the CLI command than it will for someone to do that.
tks, that worked.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24990.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24990.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24990.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-09 08:45:30 |
| Closed_By | ⇒ | SniperSister |
Merged, thanks!
@HerKle @beejay41 please test > https://docs.joomla.org/Testing_Joomla!_patches