[#24957] - Extend the attribs field to mediumtext/text in MySql and Postgres
- Closed
- 20 May 2019
- Medium
- Build: staging
- # 24957
- Diff
- pixxelfactory:staging
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
When using a content-plugin to add fields to the core content of joomla, if the user adds more content than 5160 characters, the attribs json will be truncated.
Since in the most cases using a plugin is necessary (the Field Groups / Fields ecc. do not have all functionality wich is needed on many sites), i extended the two db-fields to mediumtext / text.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Installation Postgresql |
| Labels |
Added:
?
|
||
Changed mediumtext to text
you need to add the update sql script too
You mean an update-script wich changes the existing varchar field to text (if a user updates joomla?)
Where do i need to put that?
Thanks and best regards
| Category | SQL Installation Postgresql | ⇒ | SQL Administration com_admin Installation Postgresql |
I've added the two sql-scripts, i'm not sure if the Postgres update-script is 100% correct, since i usually do not use Postgres.
Another question: Why is the continous-integration/drone/pr - Build failing?
Can you please rebase this for j4, thx
closed for rebase on j4.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-20 10:50:35 |
| Closed_By | ⇒ | franz-wohlkoenig | |
| Labels |
Added:
?
|
||
@HLeithner It would be really helpful if you could explain to the person who took the time to submit a pull request why you have closed this and asked for it to be rebased for Joomla 4.
IMO,
textis fine (and consistent withparamscolumns in other tables) butmediumtextsounds overkill. If you're storing that much JSON data, you're probably better off creating a separate table for your plugin.