? ? Success

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
20 May 2019

Pull Request for Issue # .

Summary of Changes

Per discussion in #20811, module layouts should always be rendered even if no items are available.

Testing Instructions

Create mod_articles_category override which always displays some custom message/code.
Publish Articles - Category module. Configure filtering options so that no articles are displayed.
View the module in frontend.

Expected result

Custom message shown.

Actual result

Custom message not shown.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 20 May 2019
avatar SharkyKZ SharkyKZ - change - 20 May 2019
Status New Pending
avatar SharkyKZ SharkyKZ - change - 20 May 2019
Title
[mod_articles_category] Always render module layout
[4.0][mod_articles_category] Always render module layout
avatar SharkyKZ SharkyKZ - edited - 20 May 2019
avatar SharkyKZ SharkyKZ - change - 20 May 2019
Title
[mod_articles_category] Always render module layout
[4.0][mod_articles_category] Always render module layout
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2019
Category Modules Front End
avatar SharkyKZ SharkyKZ - change - 20 May 2019
The description was changed
avatar SharkyKZ SharkyKZ - edited - 20 May 2019
avatar SharkyKZ SharkyKZ - change - 20 May 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 20 May 2019

What happens if there is no custom message? Do you end up with an empty space? If so then I stick by my comments on that discussion that this is not desirable as you "may" end up with empty columns

avatar SharkyKZ
SharkyKZ - comment - 20 May 2019

You end up with an empty column anyways. Read discussion in #20811 please (you were involved in it). There's also PR to for excluding empty modules in templates, see #19416.

avatar Quy
Quy - comment - 20 May 2019

I have tested this item successfully on afc8cfa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24956.

avatar Quy
Quy - comment - 20 May 2019

I have tested this item successfully on afc8cfa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24956.

avatar Quy Quy - test_item - 20 May 2019 - Tested successfully
avatar richard67
richard67 - comment - 31 May 2019

I have tested this item successfully on afc8cfa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24956.

avatar richard67 richard67 - test_item - 31 May 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 31 May 2019
Title
[4.0][mod_articles_category] Always render module layout
[4.0] [mod_articles_category] Always render module layout
avatar franz-wohlkoenig franz-wohlkoenig - edited - 31 May 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 31 May 2019
Title
[4.0][mod_articles_category] Always render module layout
[4.0] [mod_articles_category] Always render module layout
avatar franz-wohlkoenig franz-wohlkoenig - change - 31 May 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 31 May 2019

Status "Ready To Commit".

avatar wilsonge
wilsonge - comment - 3 Jun 2019

What happens if there is no custom message? Do you end up with an empty space? If so then I stick by my comments on that discussion that this is not desirable as you "may" end up with empty columns

#20811 (comment) you mentioned here we already have that behaviour so this change makes sense to allow customisation. However clearly we can probably improve this behaviour - but it's beyond the scope of this PR

avatar wilsonge wilsonge - change - 3 Jun 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-06-03 14:46:36
Closed_By wilsonge
avatar wilsonge wilsonge - close - 3 Jun 2019
avatar wilsonge wilsonge - merge - 3 Jun 2019
avatar wilsonge
wilsonge - comment - 3 Jun 2019

Thanks!

Add a Comment

Login with GitHub to post a comment