[#24956] - [4.0] [mod_articles_category] Always render module layout
- Fixed in Code Base
- 3 Jun 2019
- Medium
- Build: 4.0-dev
- # 24956
- Diff
- SharkyKZ:j4/modArticlesCategory2
- Success Hound No violations found. Woof! Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Per discussion in #20811, module layouts should always be rendered even if no items are available.
Testing Instructions
Create mod_articles_category override which always displays some custom message/code.
Publish Articles - Category module. Configure filtering options so that no articles are displayed.
View the module in frontend.
Expected result
Custom message shown.
Actual result
Custom message not shown.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
| Title |
|
||||||
| Title |
|
||||||
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24956.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24956.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24956.
| Title |
|
||||||
| Title |
|
||||||
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
What happens if there is no custom message? Do you end up with an empty space? If so then I stick by my comments on that discussion that this is not desirable as you "may" end up with empty columns
#20811 (comment) you mentioned here we already have that behaviour so this change makes sense to allow customisation. However clearly we can probably improve this behaviour - but it's beyond the scope of this PR
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-03 14:46:36 |
| Closed_By | ⇒ | wilsonge |
Thanks!
What happens if there is no custom message? Do you end up with an empty space? If so then I stick by my comments on that discussion that this is not desirable as you "may" end up with empty columns