? ? Success

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
18 May 2019

Pull Request for Issue #24832 for Joomla 3.x version
Same as #24944 but for staging.

Summary of Changes

This fix the subform field in IE, when one of subfield are required.

Testing Instructions

Please look for related issue for details.

avatar Fedik Fedik - open - 18 May 2019
avatar Fedik Fedik - change - 18 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 May 2019
Category JavaScript
avatar Quy
Quy - comment - 18 May 2019

I have tested this item successfully on ab3b0a4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24947.

avatar Quy Quy - test_item - 18 May 2019 - Tested successfully
avatar viocassel
viocassel - comment - 18 May 2019

I have tested this item successfully on ab3b0a4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24947.

avatar viocassel viocassel - test_item - 18 May 2019 - Tested successfully
avatar Quy Quy - change - 18 May 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 18 May 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24947.

avatar SharkyKZ
SharkyKZ - comment - 21 May 2019

@Fedik fix conflicts please.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 22 May 2019

The only conflict is in the minified version of the js file. It shouldn't be necessary to have the author of the patch fix that. Ideally the minified file shouldn't even be committed in the first place.

avatar Fedik Fedik - change - 22 May 2019
Labels Added: ?
avatar Fedik
Fedik - comment - 22 May 2019

fixed

avatar brianteeman
brianteeman - comment - 22 May 2019

@okonomiyaki3000 This is for Joomla 3 and we dont have anything setup to minify files for 3 - only j4

avatar okonomiyaki3000 okonomiyaki3000 - reference | f2a9874 - 23 May 19
avatar HLeithner
HLeithner - comment - 5 Jun 2019

@Fedik I'm sorry, could you please resolve the conflict again?

avatar franz-wohlkoenig franz-wohlkoenig - change - 5 Jun 2019
Title
Move a subform template out of the form scope, for IE compatibility.
Move a subform template out of the form scope, for IE compatibility
avatar franz-wohlkoenig franz-wohlkoenig - edited - 5 Jun 2019
avatar Fedik
Fedik - comment - 5 Jun 2019

fixed

avatar HLeithner
HLeithner - comment - 5 Jun 2019

thx

avatar HLeithner HLeithner - change - 5 Jun 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-06-05 16:36:20
Closed_By HLeithner
avatar HLeithner HLeithner - close - 5 Jun 2019
avatar HLeithner HLeithner - merge - 5 Jun 2019

Add a Comment

Login with GitHub to post a comment