Feeling Lucky
?
NPM Resource Changed
?
[#24929] - Joomla 3.9.3 Part 1
- Fixed in Code Base
- 16 May 2019
- Medium
- Build: 4.0-dev
- # 24929
- Diff
- wilsonge:merge-393-part1
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
First part of Merging Joomla 3.9.3 - all of January's commits
Merge with a merge commit. don't squash or rebase
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration SQL com_admin Postgresql com_checkin com_contact com_content com_menus com_newsfeeds com_tags com_users Language & Strings Modules JavaScript Repository NPM Change Front End Installation Libraries |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-16 21:26:44 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
NPM Resource Changed
?
|
||
infograf768
- comment
- 17 May 2019
The code is present in CheckinModel.php and Table.php
infograf768
- comment
- 17 May 2019
for the Checkin Model, looks straightforward
diff --git a/administrator/components/com_checkin/Model/CheckinModel.php b/administrator/components/com_checkin/Model/CheckinModel.php
index 44b819b..4688537 100644
--- a/administrator/components/com_checkin/Model/CheckinModel.php
+++ b/administrator/components/com_checkin/Model/CheckinModel.php
@@ -92,6 +92,4 @@
$results = 0;
- $dispatcher = \JEventDispatcher::getInstance();
-
foreach ($ids as $tn)
{
@@ -120,5 +118,5 @@
{
$results = $results + $db->getAffectedRows();
- $dispatcher->trigger('onAfterCheckin', array($tn));
+ Factory::getApplication()->triggerEvent('onAfterCheckin', array($tn));
}
}
Not sure for Table.php as we also have a $this->getDispatcher()->dispatch('onTableAfterCheckin', $event);
$this->getDispatcher()->dispatch('onTableAfterCheckin', $event);
//$dispatcher = \JEventDispatcher::getInstance();
Factory::getApplication()->triggerEvent('onAfterCheckin', array($this->_tbl));
@wilsonge
Class 'JEventDispatcher' not found when Checkin items