[#24919] - Subforms within subform rows will initialize themselves when new rows…
- Fixed in Code Base
- 20 May 2019
- Medium
- Build: staging
- # 24919
- Diff
- okonomiyaki3000:fix-subform-subform
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Subform repeatable has a function fixScripts which calls a few js initialization functions on a few of the field types that require it. There is a now a better way to handle that kind of thing by having any field that may need initialization listen for an event fired by subform repeatable. In this PR, I am transferring responsibility of one such initialization from subform repeatable to the correct field type itself.
Note: this PR doesn't really fix anything. Nest subforms already work with repeatable subforms. This just does it in a somewhat better way.
Testing Instructions
Set up a subform containing a subform. There's a subform in the redirect plugin that's simple to use for this purpose.
Open up the form and create new rows. The subform in each new row should function properly.
Expected result
Nested subforms function normally.
Actual result
Nested subforms function normally.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24919.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24919.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-20 11:46:04 |
| Closed_By | ⇒ | HLeithner |
thx
I have tested this item✅ successfully on 6e6290a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24919.