? ? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
14 May 2019

Still a work in progress

Currently working for checked out
but as a side effect it is also working elsewhere - that is to be resolved hence its a wip

avatar brianteeman brianteeman - open - 14 May 2019
avatar brianteeman brianteeman - change - 14 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2019
Category Administration Templates (admin) Libraries
avatar brianteeman brianteeman - change - 14 May 2019
Labels Added: ?
fa48a62 14 May 2019 avatar brianteeman cs
avatar Quy
Quy - comment - 18 May 2019

The tooltip displays at the top and not next to the lock icon.

Windows 10, Firefox 66.0.5

locked

avatar richard67
richard67 - comment - 19 May 2019

Can confirm Quy's result.

76c960b 8 Jun 2019 avatar brianteeman a
avatar brianteeman
brianteeman - comment - 8 Jun 2019

Can you retest please - I believe I have fixed the styling issue

avatar Quy
Quy - comment - 8 Jun 2019

Now there is an issue with the search box.
search

avatar brianteeman
brianteeman - comment - 8 Jun 2019

Will have to leave it to someone who understands css to fix ;)

avatar richard67
richard67 - comment - 9 Jun 2019

Tool tips for checked out icon and search box are placed well now.

But there is an issue with the tool tip for the published icon:

Unbenannt

Placement is good, but colours are strange.

avatar brianteeman
brianteeman - comment - 9 Jun 2019

@richard67

Currently working for checked out
but as a side effect it is also working elsewhere - that is to be resolved hence its a wip

avatar richard67
richard67 - comment - 9 Jun 2019

@brianteeman I see. So shall we wait with testing as long as a wip? Or test this PR and the rest will be done with another, new one?

avatar brianteeman
brianteeman - comment - 9 Jun 2019

@richard67 I cant replicate that tooltip on the publish icon - I dont get anything at all on hover

avatar richard67
richard67 - comment - 9 Jun 2019

@brianteeman Without this PR, I also get nothing on hover at the publish icon, but with this PR it get as shown in the screenshot above. With PR means: Clean install on current 4.0-dev with blog sampledata, then applied PR on current 4.0-dev using patchtester, then npm install, then forced page reload (shoft + reload in Firefox) in order not to use files from browser cache. Just tried it again with new clean install + blog sample data.

avatar richard67
richard67 - comment - 9 Jun 2019

@Quy Can you check if you have strange toop tip on published icon with this PR (see also my comments above)?

avatar Quy
Quy - comment - 9 Jun 2019

Same issue. It needs to be updated from popover to tooltip.

tooltip

avatar Quy
Quy - comment - 10 Jun 2019

PR #25161 fixes the popover display issue or popover not displaying.

avatar richard67
richard67 - comment - 10 Jun 2019

@Quy So this PR here is ok for the checked out icon and the search box, and PR #25161 fixes what we saw here with the publish icon?

avatar Quy
Quy - comment - 10 Jun 2019

Yes. Eventually, Brian wants to convert the popover to make it a11y.

avatar brianteeman
brianteeman - comment - 10 Jun 2019

small steps are easier to test than one massive pull request

avatar richard67
richard67 - comment - 10 Jun 2019

Not sure if I understand yet. So this PR here is ok?

avatar Quy
Quy - comment - 10 Jun 2019

Both PRs are required.

avatar richard67
richard67 - comment - 10 Jun 2019

Hmm, I see. Have to merge that manually then, patch tester detects conflict.

avatar Quy
Quy - comment - 10 Jun 2019

Yes. I manually patched the other PR to this PR.

avatar richard67
richard67 - comment - 10 Jun 2019

I have tested this item successfully on 8498942

Tooltip on the publish icon was not subject of this PR, it should be done with another one.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24899.

avatar richard67 richard67 - test_item - 10 Jun 2019 - Tested successfully
avatar richard67
richard67 - comment - 10 Jun 2019

@Quy It seems Brian wants to do the other tool tip (publish icon) with another PR, so I tested this one here ok.

avatar Quy
Quy - comment - 10 Jun 2019

I have tested this item successfully on 8498942


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24899.

avatar Quy Quy - test_item - 10 Jun 2019 - Tested successfully
avatar Quy Quy - change - 10 Jun 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 10 Jun 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24899.

avatar roland-d
roland-d - comment - 13 Jun 2019

@brianteeman Could you please fix the conflict so I can merge it? Due to PR #25161 being merged this file is in conflict.

avatar brianteeman brianteeman - change - 13 Jun 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 13 Jun 2019

resolved conflicts

avatar roland-d roland-d - change - 13 Jun 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-06-13 07:23:10
Closed_By roland-d
avatar roland-d roland-d - close - 13 Jun 2019
avatar roland-d roland-d - merge - 13 Jun 2019
avatar roland-d
roland-d - comment - 13 Jun 2019

Thanks although I am not a fan of the black with strong white text :) That is not part of this PR anyway.

avatar brianteeman
brianteeman - comment - 13 Jun 2019

@roland-d neither am I ;)

Add a Comment

Login with GitHub to post a comment