User tests: Successful: Unsuccessful:
Still a work in progress
Currently working for checked out
but as a side effect it is also working elsewhere - that is to be resolved hence its a wip
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) Libraries |
Labels |
Added:
?
|
Can confirm Quy's result.
Can you retest please - I believe I have fixed the styling issue
Will have to leave it to someone who understands css to fix ;)
Currently working for checked out
but as a side effect it is also working elsewhere - that is to be resolved hence its a wip
@brianteeman I see. So shall we wait with testing as long as a wip? Or test this PR and the rest will be done with another, new one?
@richard67 I cant replicate that tooltip on the publish icon - I dont get anything at all on hover
@brianteeman Without this PR, I also get nothing on hover at the publish icon, but with this PR it get as shown in the screenshot above. With PR means: Clean install on current 4.0-dev with blog sampledata, then applied PR on current 4.0-dev using patchtester, then npm install
, then forced page reload (shoft + reload in Firefox) in order not to use files from browser cache. Just tried it again with new clean install + blog sample data.
Yes. Eventually, Brian wants to convert the popover to make it a11y.
small steps are easier to test than one massive pull request
Not sure if I understand yet. So this PR here is ok?
Both PRs are required.
Hmm, I see. Have to merge that manually then, patch tester detects conflict.
Yes. I manually patched the other PR to this PR.
I have tested this item
Tooltip on the publish icon was not subject of this PR, it should be done with another one.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
@brianteeman Could you please fix the conflict so I can merge it? Due to PR #25161 being merged this file is in conflict.
Labels |
Added:
?
|
resolved conflicts
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-13 07:23:10 |
Closed_By | ⇒ | roland-d |
Thanks although I am not a fan of the black with strong white text :) That is not part of this PR anyway.
The tooltip displays at the top and not next to the lock icon.
Windows 10, Firefox 66.0.5