Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24898] - [4.0] Additional fields available to display in Search Results + Date ordering fix

Conflicting Files Information Required ? Failure

User tests: Successful: Unsuccessful:

avatar AndySDH
AndySDH
14 May 2019

This serves a similar purpose as this: #24897
But pertains to Search Results Articles instead of Contact Articles.

Summary of Changes

  • More Fields are made available to be used and displayed in search results for articles. This adds the ability to use the id, publish_up, introtext and images.

  • Also made sure that all of the fields have an AS alias. This wasn't the case before, where some had an alias and some didn't.

  • Finally, this makes the search results use the publish_up date instead of the created date when sorting by newest/oldest. The publish_up date makes more sense to use because it's the actual date of the article being published rather than when it was created.

Testing Instructions

None needed. Just little tweaks.

Documentation Changes Required

None.

avatar AndySDH AndySDH - open - 14 May 2019
avatar AndySDH AndySDH - change - 14 May 2019
Status New ⇒ Pending
avatar AndySDH AndySDH - change - 14 May 2019
The description was changed
avatar AndySDH AndySDH - edited - 14 May 2019
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2019
Category ⇒ Front End Plugins
avatar AndySDH AndySDH - change - 14 May 2019
Labels Added: ?
avatar AndySDH AndySDH - change - 14 May 2019
The description was changed
avatar AndySDH AndySDH - edited - 14 May 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 14 May 2019
Title
…
[Joomla 4] Additional fields available to display in Search Results + Date ordering fix
[4.0] Additional fields available to display in Search Results + Date ordering fix
avatar franz-wohlkoenig franz-wohlkoenig - edited - 14 May 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 14 May 2019
Title
…
[Joomla 4] Additional fields available to display in Search Results + Date ordering fix
[4.0] Additional fields available to display in Search Results + Date ordering fix
avatar richard67
richard67 - comment - 14 May 2019

@AndySDH Drone complains about code style. Here the extract:

FILE: /********/src/plugins/search/content/content.php

FOUND 0 ERROR(S) AND 2 WARNING(S) AFFECTING 2 LINE(S)

285 | WARNING | Line exceeds 150 characters; contains 233 characters
357 | WARNING | Line exceeds 150 characters; contains 233 characters

Can you fix that?

avatar AndySDH
AndySDH - comment - 16 May 2019

@AndySDH Drone complains about code style. Here the extract:
285 | WARNING | Line exceeds 150 characters; contains 233 characters
357 | WARNING | Line exceeds 150 characters; contains 233 characters

Done :)

avatar richard67
richard67 - comment - 16 May 2019

Drone is ok now. Appveyor failure is not related to this PR.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Jun 2019

@AndySDH can you please contact me by franz.wohlkoenig@community.joomla.org?

avatar Quy
Quy - comment - 19 Oct 2019

Please fix conflicting files.

avatar AndySDH
AndySDH - comment - 19 Oct 2019

I can't. It says "These conflicts are too complex to resolve in the web editor".

So please someone with more knowledge do this please.

avatar richard67
richard67 - comment - 19 Oct 2019

@AndySDH You are lucky because the solution is simple: File plugins/search/content/content.php has neem removed in 4.0-dev together with the whole old search plugin, the new default is smart search. So I think if you just remove file plugins/search/content/content.php from your PR, all should be fine. In the GitHub web interface you can do this (as far as I remember) by going to your PR's list of changes, going to that file and then using the "..." link at the right side of the title bar with the path to the file shows a drop-down menu where you (because you are owner) have active menu item "Delete file". Use this and commit directly to your branch patch-4, and all should be fine. Maybe not a bad idea to use the grey button to update your branch to latest base (4.0-dev) changes at the bottom of your PR after having solved the conflict by deleting the file.

avatar AndySDH
AndySDH - comment - 19 Oct 2019

Well that file was the only one that was modified in this PR :D So I guess if that file is gone, this PR is useless now :D

avatar richard67
richard67 - comment - 19 Oct 2019

@AndySDH Oh, silly me, didn't notice that. The old search plugin is still available but on a separate repository. Maybe you should make your PR there? @Hackwar can maybe advise further. This one here can be closed, I think.

avatar richard67
richard67 - comment - 19 Oct 2019

@AndySDH I've found it. Please make a PR there for the 4.0-dev branch with the changes of this PR here.
https://github.com/joomla-extensions/search/tree/4.0-dev

avatar richard67
richard67 - comment - 19 Oct 2019

@AndySDH ... and this one here you can close.

avatar AndySDH
AndySDH - comment - 19 Oct 2019

Thanks! This was a very nitpicky PR adding quality of life improvements to the component, but if it's getting decoupled from Joomla / deprecated, then it's probably not worth doing this for it anymore. Maybe could be rather good to check if Smart Search has this instead.

Can you check if Smart Search has these QOL improvements as written above in "Summary of Changes"?

avatar richard67
richard67 - comment - 19 Oct 2019

@AndySDH Not sure if I can. I am not using Smart Search normally. Maybe ask @Hackwar ? If he doesn't know, then nobody knows. He knows Smart Search quite well.

avatar Quy
Quy - comment - 4 Jan 2020

Please submit PR to https://github.com/joomla-extensions/search . Thanks.

avatar Quy Quy - change - 4 Jan 2020
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-01-04 02:31:23
Closed_By ⇒ Quy
Labels Added: Conflicting Files Information Required
avatar Quy Quy - close - 4 Jan 2020

Add a Comment

Login with GitHub to post a comment