[#24803] - [4.0] Add getMenu to the CMSApplicationInterface. Part of #24587
- Fixed in Code Base
- 7 May 2019
- Medium
- Build: 4.0-dev
- # 24803
- Diff
- wilsonge:feature/get-menu-interface
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Adds getMenu into the \Joomla\CMS\Application\CMSApplicationInterface. To test ensure menu's keep working in both the frontend and backend of the core
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-07 14:58:02 |
| Closed_By | ⇒ | wilsonge |
@wilsonge ConsoleApplication is broken because of this merge:
Class Joomla\CMS\Application\ConsoleApplication contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Joomla\CMS\Application\CMSApplicationInterface::getMenu)
Making the ConsoleApplication implement the getMenu method feels weird, I would keep it in SiteApplication.
I don't think it should that way. Plugin's use it and plugins work across all application types including console. We shouldn't have to do method exists in every application. I think we probably need to do the same ugly thing as we do in the InstallationApplication and just have it return null consistently
Ok, I trust you here :) can you do the PR?
Thanks for doing it! Sorry been on a train all day today so no good interweb
I have tested this item✅ successfully on b9653f2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24803.