NPM Resource Changed ? ? Pending
Referenced as Pull Request for: # 24993

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
5 May 2019

make sure that the switcher is always left aligned

before

image

after

image

avatar brianteeman brianteeman - open - 5 May 2019
avatar brianteeman brianteeman - change - 5 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 May 2019
Category Repository NPM Change
avatar brianteeman brianteeman - change - 7 May 2019
Labels Added: NPM Resource Changed ?
avatar brianteeman
brianteeman - comment - 10 May 2019

updated branch to trigger appveyor to run again as the error in appveyor was infrastructure and nothing to do with this pr

avatar infograf768
infograf768 - comment - 11 May 2019

We need specific switcher css for rtl as it is really broken in rtl (same in new admintemplate)

avatar brianteeman
brianteeman - comment - 11 May 2019

Everything in the new admin template is broken. There is no point doing any RTL fixes until they finish deciding what a form should look like.

avatar infograf768
infograf768 - comment - 12 May 2019

FYI, we also have issue concerning LTR for the existing code here.

.col-md-9 .switcher__legend {
   margin-left: -220px;
 }

breaks the switcher in new admin template when editing a module:
Screen Shot 2019-05-12 at 08 27 35
If taken away, we rightfully get
Screen Shot 2019-05-12 at 08 31 50

Therefore is it really useful to correct anything concerning switcher in this branch?

avatar brianteeman
brianteeman - comment - 12 May 2019

Already raised am issue on their repo. But as their repo is pretty messed up it's probably a waste of time

avatar chmst
chmst - comment - 12 May 2019

I have tested this item successfully on fe6a353

Can you give me the link to your issue on "their" repo?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24802.
avatar chmst chmst - test_item - 12 May 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 May 2019
avatar chmst
chmst - comment - 12 May 2019

thx

avatar richard67
richard67 - comment - 18 May 2019

I have tested this item successfully on fe6a353


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24802.

avatar richard67 richard67 - test_item - 18 May 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 18 May 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 May 2019

Status "Ready To Commit".

avatar roland-d roland-d - change - 18 May 2019
Labels Added: ?
avatar roland-d roland-d - change - 18 May 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-05-18 20:05:50
Closed_By roland-d
avatar roland-d roland-d - close - 18 May 2019
avatar roland-d roland-d - merge - 18 May 2019
avatar brianteeman
brianteeman - comment - 18 May 2019

Thanks

avatar Quy
Quy - comment - 23 May 2019

Please fix the switcher alignment when in the sidebar (ie edit article).

switcher

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 May 2019

@Quy can you please open a new Issue?

avatar infograf768
infograf768 - comment - 23 May 2019

PR should be simple (for the admin template we have now...)
Move in switcher.scss

.col-md-3 .switcher__legend {
  margin-left: 0;
}

after

.col-md-9 .switcher__legend,
.col-md-12 .switcher__legend {
  margin-left: -220px;
}
avatar chmst
chmst - comment - 23 May 2019

It is fixed. Did you run npm i?

avatar brianteeman
brianteeman - comment - 23 May 2019

you beat me too it @chmst

avatar infograf768
infograf768 - comment - 23 May 2019

I did
As I said, the order counts.

avatar brianteeman
brianteeman - comment - 23 May 2019

Works for me

image

avatar infograf768
infograf768 - comment - 23 May 2019

I use firefox macintosh and this is what exactly happens:

.col-md-9 .switcher__legend,
.col-md-12 .switcher__legend {
  margin-left: -220px;
}

is overriding .col-md-3

Screen Shot 2019-05-23 at 10 13 08

avatar brianteeman
brianteeman - comment - 23 May 2019

I can see it now after another rebuild
I will take a look at why later today. It makes no sense that that css is being used when it is a col-md-3

avatar infograf768
infograf768 - comment - 23 May 2019

Apologies are accepted.

avatar infograf768
infograf768 - comment - 23 May 2019

No need to look why. It is pretty obvious
Basically, as

.col-md-12 .switcher__legend {
  margin-left: -220px;
}

is loaded after col-md-3
it overrides it.

avatar brianteeman
brianteeman - comment - 23 May 2019

Not obvious to me as col-md-3 is more specific so should be the one used as far as I understand CSS. I will not submit a pr myself without understanding why

Add a Comment

Login with GitHub to post a comment