User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Repository NPM Change |
Labels |
Added:
NPM Resource Changed
?
|
We need specific switcher css for rtl as it is really broken in rtl (same in new admintemplate)
Everything in the new admin template is broken. There is no point doing any RTL fixes until they finish deciding what a form should look like.
FYI, we also have issue concerning LTR for the existing code here.
.col-md-9 .switcher__legend {
margin-left: -220px;
}
breaks the switcher in new admin template when editing a module:
If taken away, we rightfully get
Therefore is it really useful to correct anything concerning switcher in this branch?
Already raised am issue on their repo. But as their repo is pretty messed up it's probably a waste of time
I have tested this item
Can you give me the link to your issue on "their" repo?
thx
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-18 20:05:50 |
Closed_By | ⇒ | roland-d |
Thanks
PR should be simple (for the admin template we have now...)
Move in switcher.scss
.col-md-3 .switcher__legend {
margin-left: 0;
}
after
.col-md-9 .switcher__legend,
.col-md-12 .switcher__legend {
margin-left: -220px;
}
It is fixed. Did you run npm i?
I did
As I said, the order counts.
I can see it now after another rebuild
I will take a look at why later today. It makes no sense that that css is being used when it is a col-md-3
Apologies are accepted.
No need to look why. It is pretty obvious
Basically, as
.col-md-12 .switcher__legend {
margin-left: -220px;
}
is loaded after col-md-3
it overrides it.
Not obvious to me as col-md-3 is more specific so should be the one used as far as I understand CSS. I will not submit a pr myself without understanding why
updated branch to trigger appveyor to run again as the error in appveyor was infrastructure and nothing to do with this pr