[#24786] - [4.0] Form Field Standardization
- Closed
- 18 Nov 2019
- Medium
- Build: 4.0-dev
- # 24786
- Diff
- James-Antrim:4.0-dev
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Removed the unused attribute $inputType possible duplicate of $options.
Removed the inappropriate attribute $accept from several files.
Removed the redundant and incorrect attribute $spellcheck from several files.
Alphabetized CheckboxField attributes.
Outsourced the CheckboxField HTML generation to a layout.
Removed redundant options setting from ComboField and TagField.
Testing Instructions
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout Libraries |
| Labels |
Added:
?
|
||
franz-wohlkoenig
- | Title |
|
||||||
| Category | Layout Libraries | ⇒ | SQL Administration com_admin Postgresql com_workflow Language & Strings Installation Layout |
| Labels |
Added:
?
|
||
| Category | Layout SQL Administration com_admin Postgresql com_workflow Language & Strings Installation | ⇒ | Administration com_workflow Language & Strings Postgresql SQL Installation Layout |
| Category | Layout SQL Administration Postgresql com_workflow Language & Strings Installation | ⇒ | Administration com_workflow Language & Strings Layout |
@James-Antrim There are some unrelated changes here, possibly due to conflicts. Are you going to update this PR?
| Labels |
Added:
?
|
||
@James-Antrim There are some unrelated changes here, possibly due to conflicts. Are you going to update this PR?
As far as I am concerned this is done.
The continuous integration errors have nothing to do with my code.
Someone is modifying the h1.page-title after it has already been rendered, giving it an id with the modified contents of the icon span. The title layout was last changed in 2017 by 'Walsh' and the mod_title default was last modified in 2018 by yourself. Upto and including the default.php for mod_title the output is as expected. What some js somewhere does after the fact is not my business.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-11 14:07:28 |
| Closed_By | ⇒ | James-Antrim |
Tests are probably unrelated. I'm referring to some Workflow-related changes you have in here. They seem to be added by mistake as they not related to "Form Field Standardization"?
Tests are probably unrelated. I'm referring to some Workflow-related changes you have in here. They seem to be added by mistake as they not related to "Form Field Standardization"?
Yes. I had mistakenly not opened a new branch for a workflow related commit. The changes to the workflow part have already been made a part of Benjamin's workflow fork, and my commits reverting my change from constant to text back to a constant were already done there, as I believe I wrote in my reply to Brian. At Brian's suggestion I reverted them in this as well as it had already made it into the 4.0 branch. The still unmerged changes should only be that revert, no new code per se.
| Status | Closed | ⇒ | New |
| Closed_Date | 2019-07-11 14:07:28 | ⇒ | |
| Closed_By | James-Antrim | ⇒ |
| Status | New | ⇒ | Pending |
But Workflow changes are still included in this PR.
Could you include some testing instructions, please?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24786.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-18 08:07:28 |
| Closed_By | ⇒ | James-Antrim | |
| Labels |
Added:
?
Removed: ? |
||
Test instructions?