Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24777] - [4.0] Show the correct modal for a given extension

NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar roland-d
roland-d
4 May 2019

Pull Request for Issue #24744 .

Summary of Changes

This fixes the issue of always showing the same modal.

Testing Instructions

  1. Go to the backend
  2. Click on System -> Extensions -> Manage
  3. Filter on Kunena
  4. Click on the version number of multiple extensions and check the modal title. This will say Kunena - AltaUserPoints Integration for all extensions you click.
  5. Install the Kunena 6 nightly build (https://www.kunena.org/download#joomla-60)
  6. Click on System -> Extensions -> Manage
  7. Filter on Kunena
  8. Click on the version number of multiple extensions and check the modal title. This will say Kunena - AltaUserPoints Integration for all extensions you click.

Expected result

Modal is showing the correct title

Actual result

Modal is always showing the title of the first extension with a changelog

Documentation Changes Required

None

@810

avatar roland-d roland-d - open - 4 May 2019
avatar roland-d roland-d - change - 4 May 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 May 2019
Category ⇒ Administration com_installer JavaScript Repository NPM Change
avatar roland-d roland-d - change - 4 May 2019
Labels Added: NPM Resource Changed ?
avatar franz-wohlkoenig franz-wohlkoenig - change - 4 May 2019
Title
…
Show the correct modal for a given extension
[4.0] Show the correct modal for a given extension
avatar franz-wohlkoenig franz-wohlkoenig - edited - 4 May 2019
avatar roland-d
roland-d - comment - 4 May 2019

Drone failure is not related to this PR:

 Test  libraries/vendor/joomla/test-system/src/acceptance/administrator/components/com_menu/MenuCest.php:createNewMenu
                                                                                                            
  [Facebook\WebDriver\Exception\TimeOutException] Waited for 10 secs but text 'Menus: Add' still not found
avatar infograf768
infograf768 - comment - 4 May 2019

For Information, this is a new feature in 4.0
See https://docs.joomla.org/Adding_changelog_to_your_manifest_file

avatar brianteeman
brianteeman - comment - 4 May 2019

Shouldnt the javascript be in a dedicated file for com_installer and then added with the web asset manager instead of being included in the generic core.js

avatar 810
810 - comment - 4 May 2019

I have tested this item ✅ successfully on a32c97e

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24777.

avatar 810 810 - test_item - 4 May 2019 - Tested successfully
avatar wilsonge
wilsonge - comment - 4 May 2019

Shouldnt the javascript be in a dedicated file for com_installer and then added with the web asset manager instead of being included in the generic core.js

Yes - but outside of the scope for this PR

avatar wilsonge wilsonge - change - 4 May 2019
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-05-04 13:32:48
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 4 May 2019
avatar wilsonge wilsonge - merge - 4 May 2019
avatar wilsonge
wilsonge - comment - 4 May 2019

Thanks!

Add a Comment

Login with GitHub to post a comment