J3 Issue ?
avatar joomlahenk
joomlahenk
29 Apr 2019

Steps to reproduce the issue

Change custom field option show-on from site to administrator

Expected result

Custom field tab is not displayed in front-end edit, but is displayed in backend edit
The custom field IS displayed on the actual site

Actual result

Custom field tab not displayed in front-end edit, but is displayed in backend edit
The custom field is NOT displayed on the actual site

System information (as much as possible)

J! 3.9.5

Additional comments

Refers to issue #24397
As already commented by duvi:
The "Show on" setting should only affect where the field should be visible in the EDIT view - in admin, in front end or both.

If you don't want the CF to display on site, you just unpublish

Please UNDO this.

avatar joomlahenk joomlahenk - open - 29 Apr 2019
avatar joomla-cms-bot joomla-cms-bot - change - 29 Apr 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 29 Apr 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Apr 2019
Labels Added: J3 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 29 Apr 2019
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Apr 2019

@alikon can you please comment as #24397 is created by you?

avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Apr 2019
Status New Information Required
avatar alikon
alikon - comment - 30 Apr 2019

imo #24397 is correct/expected behaviuor

avatar joomlahenk
joomlahenk - comment - 30 Apr 2019

The issue I have after this change is that all custom fieds on my site disappear after update to 3.9.5.
This was because I had set show-on to administrator as I don't want a user to see a tab for the CF in the editor when he wants to edit an article in the front end.

Now I need to set show-on to site to have it show on the site and then the user has a tab for the CF in the editor in the front end, although he is not allowed to change the CF.

Maybe there needs to be a better description of what this setting is ment to do.
Do we use it for the EDIT view or for the SITE view or a mix of both?
I think it is realy needed to be able to show/not-show the CF tab in the front-end edit

avatar alikon
alikon - comment - 30 Apr 2019

from https://docs.joomla.org/J3.x:Adding_custom_fields/Parameters_for_all_Custom_Fields

Show on
On which part of the site should the field be shown. In the backend, in the frontend or both?

avatar joomlahenk
joomlahenk - comment - 30 Apr 2019

Show on
On which part of the site should the field be shown. In the backend editor, in the frontend editor or both?
The backend is used for editing.
The frontend is the site as anyone can see it.
The frontend editor is used by a user that logs-in on the frontend and does not use the backend.
So it this case we have 3 viewing modes not just 2.

Changing this setting should not have any inpact on the site as anyone can see it.

avatar kat0d
kat0d - comment - 12 May 2019

@alikon alikon and where is the

  • Disabled: Should the field be disabled in the edit form.
  • Read only: Should the field be read-only in the edit form.
    parameters ???
    image
avatar AndySDH
AndySDH - comment - 14 May 2019

The "Show on" setting should only affect where the field should be visible in the EDIT view - in admin, in front end or both.

If you don't want the CF to display on site, you just unpublish

Agreed.

That setting has always been for controlling where the field can be edited.

It just has a bad description.

So the correct thing to do is that the "Show on" setting should be renamed to "Can be edited in..."
with options: Backend/Frontend/Both

And #24397 should indeed be un-done.

avatar AndySDH
AndySDH - comment - 28 May 2019

Just a reminder for this. Please @alikon can you check this?

avatar alikon
alikon - comment - 28 May 2019

feel free to submit a pr, i've already said my pov on this matter #24754 (comment)

avatar AndySDH
AndySDH - comment - 28 May 2019

@alikon Sorry but did you read my post here? That description is badly worded to begin with.

"On which part of the site should the field be shown. In the backend, in the frontend or both?"

This is just bad wording and not the intended functionallity. Custom Fields already have a setting that controls whether the custom field should be displayed or not on the frontend. This:

image

So there already is a setting that controls the display on the frontend or not.

The current setting called "Show on" is and was always meant to be an option for where the custom field could be edited, not where it could be displayed. It was just bad wording of the description.

Please don't be "stubborn" just because this would undo something you did, please try to understand the situation as it's something that was misinterpreted.

avatar AndySDH
AndySDH - comment - 28 May 2019

Also another proof that the option was only meant to be for the editing form, and not the frontend display, is that the method is called "displayFieldOnForm"

See, key word: OnForm.

image

So right now you added a check for the frontend display based on an option that was meant for the edit form display.

Please try to work with us man!

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 May 2019

Closed as having Pull Request #25062

avatar franz-wohlkoenig franz-wohlkoenig - close - 30 May 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 30 May 2019
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2019-05-30 08:35:01
Closed_By franz-wohlkoenig

Add a Comment

Login with GitHub to post a comment