Feeling Lucky
?
?
[#24753] - [4.0] Add the modules ID to the form html ID
- Closed
- 28 Apr 2019
- Medium
- Build: 4.0-dev
- # 24753
- Diff
- uglyeoin:patch-12
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Adds the module ID to the HTML ID so that the HTML ID is always unique
Testing Instructions
Add a login module to the front end
Inspect the source code and see that the login module has an id of id="login-form"
Install the patch
Inspect the login form and see that the module now has an ID with a module number added to the end of it. e.g. id="login-form-16"
Expected result
ID's should always be unique
Actual result
ID is static but module can be replicated.
You see the correct module ID attached to the ID making it unique
Documentation Changes Required
n/a
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin |
| Title |
|
||||||
| Title |
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-28 20:35:17 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
This is fine. But you need to start the PR from the 4.0-dev branch. Not from the staging branch. I'm still not synced up yet - so you had a billion conflicts and commits