[#24743] - [4.0] Fix tags creation
- Fixed in Code Base
- 28 Apr 2019
- Medium
- Build: 4.0-dev
- # 24743
- Diff
- wilsonge:bug/tags-field
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Currently the creation of dynamic tags is broken in the 4.0 branch. This fixes it (has been the case since we merged the update of choices 7)
Testing Instructions
Type a tag with a new value into the tags box and hit enter
Expected result
Tag is created
Actual result
It isn't
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24743.
I have tested this item
>>This fixes it (has been the case since we merged the update of choices 7)
Not true. It never worked correctly since Joomla 4 used choices v 3.0.4.
And thanks to the great work of @bembelimen and @dgrammatiko on this script.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24743.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
Not true. It never worked correctly since Joomla 4 used choices v 3.0.4.
it did because i tested downgrading the version and it worked ;)
@franz-wohlkoenig it definitely doesn't fix the first issue and i can't reproduce the second (although as hannes suggested on the second it was related to setup doesn't mean it's fixed)
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Pending |
Status set on Pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24743.
| Labels |
Removed:
?
|
||
@franz-wohlkoenig just a codestyle fix for hound. No need to retest. As soon as tests pass i'm going to merge
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-28 14:06:20 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
NPM Resource Changed
?
|
||
Thanks guys!
Are #23748 #23589 related Issues?