Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24709] - [4.0] opcache invalidate

? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
23 Apr 2019

Pull Request for Issue #24678 .

Summary of Changes

porting of #21949 on 4.x

Testing Instructions

see #24678

Expected result

setting saved in global configuration setting

Actual result

not saved at 1st save

avatar alikon alikon - open - 23 Apr 2019
avatar alikon alikon - change - 23 Apr 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Apr 2019
Category ⇒ Administration com_config
avatar wilsonge
wilsonge - comment - 23 Apr 2019

If we're doing this we should probably call the full suite of functions

joomla-cms/administrator/components/com_joomlaupdate/restore.php

Lines 8317 to 8333 in 34faac6

// opcode cache busting before including the filename
if (function_exists('opcache_invalidate'))
{
opcache_invalidate($filename);
}
if (function_exists('apc_compile_file'))
{
apc_compile_file($filename);
}
if (function_exists('wincache_refresh_if_changed'))
{
wincache_refresh_if_changed(array($filename));
}
if (function_exists('xcache_asm'))
{
xcache_asm($filename);
}

avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Apr 2019
Title
…
[4.0][com_config] opcache invalidate
[4.0] opcache invalidate
avatar franz-wohlkoenig franz-wohlkoenig - edited - 23 Apr 2019
avatar alikon
alikon - comment - 23 Apr 2019

i've only opcache available to test ? ....

avatar ghazal
ghazal - comment - 23 Apr 2019

Something should be done one way or the other.
Anyhow this works.

avatar twister65
twister65 - comment - 25 Apr 2019

OPcache improves PHP performance by storing precompiled script bytecode in shared memory, thereby removing the need for PHP to load and parse scripts on each request.
This extension is bundled with PHP 5.5.0 and later.

OPcache is the most usual. It is used on cloudaccess.net servers. I think the others are optional, as I did in these commits:
76b4634
eb5c9b5
Some of the other functions are not longer maintained and are deprecated.
See joomla-framework/filesystem#19 (comment)

avatar twister65
twister65 - comment - 5 May 2019

I have tested this item ✅ successfully on ede7190

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24709.

avatar twister65 twister65 - test_item - 5 May 2019 - Tested successfully
avatar wilsonge
wilsonge - comment - 5 May 2019

This has effectively been merged with the merging in of 3.9.1 earlier today. I still think we should add in all the cache functions that we support officially (obviously no issues dropping the ones no longer required in php 7)

avatar wilsonge wilsonge - close - 5 May 2019
avatar wilsonge wilsonge - change - 5 May 2019
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-05-05 12:51:21
Closed_By ⇒ wilsonge
Labels Added: ?

Add a Comment

Login with GitHub to post a comment