? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
23 Apr 2019

Summary of Changes

  1. Move the legacy controller loading code into the catch block, it's rather easy when reading the file to think all of that code should be executed but in reality it is a fallback if the factory fails to create a controller

  2. Trigger deprecation notices when adding new paths or loading controllers through the legacy code path

Testing Instructions

Code review, the odds of anyone having some pre-existing code implementing a custom cache controller laying around are pretty slim.

avatar mbabker mbabker - open - 23 Apr 2019
avatar mbabker mbabker - change - 23 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Apr 2019
Category Libraries
avatar wilsonge wilsonge - change - 24 Apr 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-24 08:53:59
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 24 Apr 2019
avatar wilsonge wilsonge - merge - 24 Apr 2019
avatar wilsonge
wilsonge - comment - 24 Apr 2019

Thanks!

Add a Comment

Login with GitHub to post a comment