? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
23 Apr 2019

Pull Request for Issue #24697

Enables UTF8MB4 support in the database drivers when available

avatar wilsonge wilsonge - open - 23 Apr 2019
avatar wilsonge wilsonge - change - 23 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Apr 2019
Category Libraries
avatar wilsonge wilsonge - change - 23 Apr 2019
Title
Enable utf8mb4 in database connections
[4.0] Enable utf8mb4 in database connections
avatar wilsonge wilsonge - edited - 23 Apr 2019
avatar infograf768
infograf768 - comment - 23 Apr 2019

Does not solve the issue here.

avatar brianteeman
brianteeman - comment - 23 Apr 2019

:) same error for me after applying the patch and trying to create an article with an emoji as the title
Save failed with the following error: Incorrect string value: '\xF0\x9F\x8E\x81\xE2\x9C...' for column 'title' at row 1

avatar brianteeman
brianteeman - comment - 23 Apr 2019

correction:
I still cannot insert an emoji in the title of a new article
But I can now insert an emoji in the title of an existing article

The difference between the two cases is either due to the INSERT vs UPDATE in the sql
OR it is failing at the create alias stage

avatar mbabker
mbabker - comment - 23 Apr 2019

It might not fix that issue, but it does in general fix the configuration issue of utf8mb4 needing to be explicitly enabled in the driver config. So, this should still be merged but further troubleshooting of #24697 might be needed.

avatar wilsonge
wilsonge - comment - 23 Apr 2019

OK So at minimum I'd hope that the Database Connection Collation screenshot in the original PR is switched to be utf8mb4. Can you guys confirm?

avatar chetanmadaan
chetanmadaan - comment - 23 Apr 2019

@wilsonge
The Database Connection Collation still reads utf8_general_ci, before and after the patch with both (Mysqli and Mysql (PDO), DB drivers.

avatar wilsonge wilsonge - change - 23 Apr 2019
Labels Added: ?
avatar wilsonge
wilsonge - comment - 23 Apr 2019

Ugh I made a really stupid bug in the code. Can you try again please

avatar chetanmadaan
chetanmadaan - comment - 23 Apr 2019

Checking now...

avatar chetanmadaan
chetanmadaan - comment - 23 Apr 2019

Awesome.

System config now reads collect collation for both DB Drivers and I am able to save Emoji's as well.

Database Connection Collation |
-- | --
utf8mb4_general_ci

avatar wilsonge
wilsonge - comment - 23 Apr 2019

This passed on drone but it hasn't apparently sent the response back to github http://ci.joomla.org/joomla/joomla-cms/17341 :(

avatar wilsonge wilsonge - change - 23 Apr 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-23 16:02:24
Closed_By wilsonge
avatar wilsonge wilsonge - close - 23 Apr 2019
avatar wilsonge wilsonge - merge - 23 Apr 2019
avatar wilsonge
wilsonge - comment - 23 Apr 2019

Merging with the good test and @mbabker 's review

avatar brianteeman
brianteeman - comment - 23 Apr 2019

Just confirming it worked for me too


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24704.

avatar brianteeman
brianteeman - comment - 23 Apr 2019

Just confirming it worked for me too


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24704.

avatar chetanmadaan
chetanmadaan - comment - 23 Apr 2019

Further confirmed that the emoji's work on new and existing articles and in title and article description as well.
image

image

Thank you @wilsonge for the promptness in getting this done.

avatar wilsonge
wilsonge - comment - 23 Apr 2019

No worries. Thanks for reporting it!

Add a Comment

Login with GitHub to post a comment