[#24654] - [4.0] Fix modals tabbing in media manager
- Fixed in Code Base
- 21 Apr 2019
- Medium
- Build: 4.0-dev
- # 24654
- Diff
- wilsonge:feature/media-a11y-modals
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Fix the tabbing of modals in media manager. Before the PR tabs are totally locked on the input element in both the create folder and the rename modal. After this PR the focus in all modals is locked to the modal. However all elements in that (buttons etc) can be tabbed into.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change JavaScript |
| Title |
|
||||||
I have tested this item
1. Checked modals for file rename and file creation in media manager.
2. Applied patch with patchtester.
3. Did composer install and nmp install.
4. Checked modals for file rename and file creation in media manager.
Result:
Before patch no tabbing inside modals.
After patch tabbing inside modals is possible.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24654.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24654.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-21 17:30:21 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
NPM Resource Changed
?
|
||
Thanks guys!
Thanks too.
Great will put it on todays test list