? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
21 Apr 2019

Pull Request for Issue #24649 .

Summary of Changes

correct timestamp for postgresql

Testing Instructions

see #24649

Expected result

no error on postgresql

Actual result

error on postgresql

avatar alikon alikon - open - 21 Apr 2019
avatar alikon alikon - change - 21 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Apr 2019
Category Front End com_banners
avatar twister65
twister65 - comment - 21 Apr 2019

In Components->Banners->Tracks, the hour is not localized.
I think, it is another issue.

avatar alikon alikon - change - 21 Apr 2019
Labels Added: ?
avatar alikon
alikon - comment - 21 Apr 2019

yes another issue

avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Apr 2019
Title
[com_banners] - fix track date
Banners - fix track date
avatar franz-wohlkoenig franz-wohlkoenig - edited - 21 Apr 2019
avatar twister65
twister65 - comment - 21 Apr 2019

I have tested this item successfully on 2ae67e1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24652.

avatar twister65 twister65 - test_item - 21 Apr 2019 - Tested successfully
avatar viocassel
viocassel - comment - 21 Apr 2019

I have tested this item successfully on 2ae67e1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24652.

avatar viocassel viocassel - test_item - 21 Apr 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Apr 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Apr 2019

Status "Ready To Commit".

avatar alikon alikon - change - 22 Apr 2019
Labels Added: ?
avatar HLeithner HLeithner - change - 22 Apr 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-22 08:20:12
Closed_By HLeithner
avatar HLeithner HLeithner - close - 22 Apr 2019
avatar HLeithner HLeithner - merge - 22 Apr 2019
avatar HLeithner
HLeithner - comment - 22 Apr 2019

thx

avatar twister65
twister65 - comment - 22 Apr 2019

Please, see #24651 (comment).
I apologize, I did not pay attention during my test.
See PR #8825 too.

avatar twister65
twister65 - comment - 22 Apr 2019

The banners page shows an overview of how many impressions and clicks a banner has received, while the tracks page shows you impression and click data based upon each hour of the day.
See:
#8825 (comment)

avatar twister65
twister65 - comment - 30 Apr 2019

This PR should not be merged, it raises a new issue (see #24651 (comment)).
Please, test this PR #24651 instead.

Add a Comment

Login with GitHub to post a comment