[#24652] - Banners - fix track date
- Fixed in Code Base
- 22 Apr 2019
- Medium
- Build: staging
- # 24652
- Diff
- alikon:patch-121
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_banners |
In Components->Banners->Tracks, the hour is not localized.
I think, it is another issue.
| Labels |
Added:
?
|
||
yes another issue
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24652.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24652.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-22 08:20:12 |
| Closed_By | ⇒ | HLeithner |
thx
Please, see #24651 (comment).
I apologize, I did not pay attention during my test.
See PR #8825 too.
The banners page shows an overview of how many impressions and clicks a banner has received, while the tracks page shows you impression and click data based upon each hour of the day.
See:
#8825 (comment)
This PR should not be merged, it raises a new issue (see #24651 (comment)).
Please, test this PR #24651 instead.
Yes, it works too. You've just forgotten the click track:
https://github.com/alikon/joomla-cms/blob/aee4b63f8747a06afcc03494cddeba66e79f518b/components/com_banners/models/banner.php#L81