Joomla! Issue Tracker | Joomla! CMS #24651 - Fix timestamp format for track

? ?

Fixed in Code Base
17 Mar 2022
Medium
Build: staging
# 24651
Diff
twister65:banner

Success

Success Hound No violations found. Woof! Details
Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
Success continuous-integration/drone/pr Build is passing Details

User tests: Successful: Unsuccessful:

twister65
21 Apr 2019

Pull Request for Issue #24649.

Summary of Changes

Timestamp format.

Testing Instructions

Added Instructions from #24649 (comment) by @franz-wohlkoenig:

Install Joomla with examples. The database must be postgreSQL.
Go to Components->Banners->Banners.
Click Support Joomla! banner.
Click the Banner Details tab.
Select Yes for "Track Impressions" and "Track Clicks".
Go to the example site: index.php/using-joomla/extensions/modules/display-modules/banner

76b4634 1 Sep 2018

Fix Editor change does not work #21943

cd5ae11 1 Sep 2018

Update Factory.php

eb5c9b5 2 Sep 2018

omit caching functions

9349b82 2 Sep 2018

Invalidates the cached configuration file

f575cd1 2 Sep 2018

Invalidates cached file after write

c899ab1 2 Sep 2018

Update application.php

429b80b 2 Dec 2018

Merge remote-tracking branch 'upstream/staging' into staging

3fedf74 6 Apr 2019

Merge remote-tracking branch 'upstream/staging' into staging

edc19d5 21 Apr 2019

Merge branch 'staging' of https://github.com/joomla/joomla-cms into staging

cd667d8 21 Apr 2019

Fix issue #24649

twister65 - open - 21 Apr 2019

twister65 - change - 21 Apr 2019

Status

New

⇒

Pending

joomla-cms-bot - change - 21 Apr 2019

Category

⇒

Front End com_banners

twister65 - comment - 21 Apr 2019

We have #24652.

twister65 - change - 21 Apr 2019

Status	Pending	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2019-04-21 09:58:53
Closed_By		⇒	twister65
Labels	Added: ?

twister65 - close - 21 Apr 2019

twister65 - head_ref_deleted - 21 Apr 2019

twister65 - head_ref_restored - 22 Apr 2019

twister65 - comment - 22 Apr 2019

Reopened because the PR #24652 adds a new row for each banner track at anytime.
The counter is always 1.
We want to add a new row every hour and increment the counter.

twister65 - reopen - 22 Apr 2019

twister65 - change - 22 Apr 2019

Status	Closed	⇒	New
Closed_Date	2019-04-21 09:58:53	⇒
Closed_By	twister65	⇒

twister65 - change - 22 Apr 2019

Status

New

⇒

Pending

twister65 - reopen - 22 Apr 2019

franz-wohlkoenig - change - 24 Apr 2019

The description was changed

franz-wohlkoenig - edited - 24 Apr 2019

5404d21 5 May 2019

Merge branch 'staging' into banner

twister65 - comment - 5 May 2019

@HLeithner , for review please.
See #24652 (comment)

Pinkeltje - test_item - 23 Aug 2019 - Tested successfully

Pinkeltje - comment - 23 Aug 2019

I have tested this item ✅ successfully on 5404d21

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24651.}

Hackwar - comment - 23 Aug 2019

This unfortunately is the wrong way to fix this. We still need to format this with ->toSQL(), since the used format() might not be the right format for the RDBMS. So you would have to modify the trackdate or create a helper trackdate which you can then format with ->toSQL.

d5d3b6a 23 Aug 2019

Merge branch 'staging' into banner

06d45be 24 Aug 2019

Format trackdate to SQL.

1a7c59f 24 Aug 2019

Merge branch 'staging' into banner

0814dab 24 Aug 2019

Format trackdate in 2 steps.

43ebd61 24 Aug 2019

Merge branch 'banner' of https://github.com/twister65/joomla-cms into banner

twister65 - comment - 24 Aug 2019

@Hackwar , is that what you expect ?

Hackwar - comment - 24 Aug 2019

I expected something along the lines of ->setMinutes(0) or something like that, but I think date objects are immutable... So it isn't really a nice solution, but should work...