? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
15 Apr 2019

Replaces #24573 as com_privacy structure is now namespaced

Summary of Changes

Adapt mod_privacy_dashboard to j4 as was done here: #24563

Before patch

Screen Shot 2019-04-13 at 10 28 36

### After patch

Screen Shot 2019-04-13 at 10 15 55

@alikon @ghazal

avatar infograf768 infograf768 - open - 15 Apr 2019
avatar infograf768 infograf768 - change - 15 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2019
Category Administration Modules
avatar infograf768 infograf768 - change - 15 Apr 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 15 Apr 2019

The Total Request and Active Requests should not be part of the table. They are not related to anything in the table headers. If you read down the columns you can see that the data here is nothing to do with the rest of the data in the columns.

As this is not related to the table it should be outside of the table and as it is not tabular data it can simply be a new div

avatar brianteeman
brianteeman - comment - 15 Apr 2019

There is no need for the data-original-title attribute either as you have removed the class=hasTooltip

avatar infograf768
infograf768 - comment - 16 Apr 2019

<div> would not work. BTW, this is what we have in 3.x:
Screen Shot 2019-04-16 at 05 54 29

To avoid alignment with the headers I have added colspans to keep things together and centering the total and active requests to get this:

Screen Shot 2019-04-16 at 05 54 47

avatar brianteeman
brianteeman - comment - 16 Apr 2019

It is 2019. Please do not misuse tables for display purposes

avatar infograf768
infograf768 - comment - 16 Apr 2019

You know better, as usual. Then make the patch yourself.

avatar infograf768 infograf768 - change - 16 Apr 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-04-16 08:45:27
Closed_By infograf768
avatar infograf768 infograf768 - close - 16 Apr 2019
avatar brianteeman
brianteeman - comment - 16 Apr 2019

Thank you for your kind words

Add a Comment

Login with GitHub to post a comment