[#24591] - [4.0] Template styles Toolbars: add alert when setting Default + use Toolbar class
- Closed
- 7 Apr 2022
- Medium
- Build: 4.0-dev
- # 24591
- Diff
- infograf768:4.0_template_styles_alert
- Success Hound No violations found. Woof! Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Failure continuous-integration/drone/pr Build is failing Details
- Failure JTracker/HumanTestResults Human Test Results: 0 Successful 2 Failed. Details
User tests: Successful: Unsuccessful:
See discussion #24541
Summary of Changes
Using new Toolbar class all over the view.
Displaying a confirm alert when setting a style as Default
Before patch
One can choose multiple template styles and use Default button, therefore setting as Default the style with the lower id.
After patch
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates Language & Strings |
Yes, this would be the ideal.
I am sure you will find a better way with the existing toolbar code we have in J4.
| Labels |
Added:
?
?
|
||
I have tested this item
I think there is some work needed. The message is displayed everytime you click on the default button. Even when only one style is selected. When I select more than one style and I confirm the errormessage one of the selected is set to default. I think this is no good workflow.
It would be better if the message only displays when more than one styles are selected. Furthermore it would be better, that only one button is on the Message, and if you click it you will get back to the selection you did and you has the option to update your selection.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24591.
A simple solution is to remove the Default button and use the Default column to select the default.
@infograf768 Do you want to fix the merge conflicts or should this PR be closed?
I have tested this item
Patchtester returns an error on apply
The file marked for modification does not exist: administrator/components/com_templates/View/Styles/HtmlView.php
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24591.
@infograf768 thanks for your pr. Can you fix the conflicts please and rebase to the 4.2-dev branch? In the meantime I'm closing the pr. When ready please reopen again so we can make another test round as this is a welcome change to stabilize the template manager.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-07 06:40:20 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
Language Change
?
Removed: ? ? |
||
Personally I believe this to be the wrong approach for j4 and the button should be disabled instead