I have tested this PR successfully.
But the Publish and Unpublish buttons are displayed ReadOnly in this case and Should be Accessible.

how can that be a successful test then?

I have tested this item 🔴 unsuccessfully on 3872a11

It is now impossible to do anything

how can that be a successful test then?

Sorry,
I meant the styling as read-only, the buttons were working and no error message was displayed as discussed in the issue

Which confirms that it is an unsuccessful test as obviously introducing a new bug is a failure

does reloading of the page,(Probably sending a request to backend) on clicking on one Un-highlighted button, when a single article is selected considered to be an expected behavior??

@brianteeman It is not a new bug, The buttons were readonly earlier as well, as 1 of the article is published. I will make changes to restore the active status asap

@bahl24 apologies then

@brianteeman Should I remove the feature that publish button is disabled when we try to publish an already published item or modify the condition to not disable the button if an unpublished item is selected along with published item?
What is the expected behaviour, J3 has no such feature for disabling workflow buttons?

@brianteeman Apology for the linting errors, but I have modified the condition for disabling of workflow buttons. Now Publish button will only be disabled only when all the selected items are published & active even if 1 of the selected is unpublished/archived/trashed (which is the expected behaviour).
Similarly for other workflow buttons.

I have tested this item ✅ successfully on 53a6698

+1

I have tested this item ✅ successfully on 53a6698

+1

I have tested this item ✅ successfully on 53a6698

rtc

restarted drone

@infograf768 @Puneet-Jain-18 please retest.

Sorry this PR makes absolutely no sense.

• Why should we skip published items? The "publish" method is a generic method for all states (also for unpublish etc). So unpublishing a published item could be very hard.
• don't rely on the state field. The correct value is in the condition (state is only for b/c)
• we're in Joomla! 4 now, there is a reason for this message. Publish != Publish now. It depends on the transitions. So if you're not allowed to execute the transition or there is none, you should get an error. (Just think: all of your articles are unpublished conditionwise, now you mark them and press publish, but there is no transition available, then nothing would happen (if the intention of this PR is correct implemented) that would confuse the user)

So please do not change the behaviour without seeing the big picture.

The problem, if this error appears is, that someone changed some code so a user can execute the publish call without transition available.

After checking the behaviour, it seems something throws an JS error, which breaks the initial check.
So fixing the JS error should recover the correct behaviour => you can't execute something without transition.

@bembelimen Actually, the issue is when we mark 1 published & one unpublished article, and execute publish the unpublished article remains the same. It should be published IMO.
I will change the code to just continue and not return, that way it will just execute the publishing operation. Do you agree?

No, as stated above, please fix the JS error (in another PR) and then we can look again.

The issue is a combination of several bugs which we can solve, but not with this if

Closed, see #24621