Feeling Lucky
NPM Resource Changed
?
[#24449] - [4.0] Fix Article Versions JS error
- Fixed in Code Base
- 4 May 2019
- Medium
- Build: 4.0-dev
- # 24449
- Diff
- Arpit-24:4.0-ie11-versions
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #23811 .
Summary of Changes
Added special function that will be used when browser is IE11 and returns the closest element
Testing Instructions
npm ci is required
In IE11, open any article in your Article Manager
Click the "Versions" button
Check any of the checkboxes
Actual result
No error in console now
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
C-Lodder
- comment
- 4 Apr 2019
At work so can't properly test.
Looks fine from a code review. Just need to fix the Hound violations
Arpit-24
- comment
- 4 Apr 2019
At work so can't properly test.
Looks fine from a code review. Just need to fix the Hound violations
Fixed hound violations
| Category | Administration Templates (admin) JavaScript Repository NPM Change | ⇒ | Administration JavaScript Repository Templates (admin) |
| Title |
|
||||||
| Category | Administration Templates (admin) JavaScript Repository | ⇒ | Administration Templates (admin) JavaScript Repository NPM Change |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-04 17:02:04 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Removed:
J4 Issue
|
||
wilsonge
- comment
- 4 May 2019
Thanks!
@C-Lodder please test.