NPM Resource Changed ? ? ? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
1 Apr 2019

When creating a user in the admin we can see a password strength meter.

Currently the meter has an aria-describedby value of the following text.

This is not correct as the meter never receives focus. The text needs to have an aria-live value so that when the text is updated it is announced.

This PR corrects that using the technique from https://www.w3.org/WAI/tutorials/forms/examples/password/

There is no visual change
Viewing the source you will see that the aria-describedby in the progress bar div is now an id
And that the aria-live polite value has been added to the text div

requires npm install to test

avatar brianteeman brianteeman - open - 1 Apr 2019
avatar brianteeman brianteeman - change - 1 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2019
Category JavaScript Repository NPM Change
avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Apr 2019
Category JavaScript Repository NPM Change JavaScript Repository
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Apr 2019
Title
[4.0] Password strength [a11y]
[4.0] Password strength
avatar franz-wohlkoenig franz-wohlkoenig - edited - 19 Apr 2019
avatar joomla-cms-bot joomla-cms-bot - change - 19 Apr 2019
Category JavaScript Repository JavaScript Repository NPM Change
avatar brianteeman brianteeman - change - 2 May 2019
The description was changed
avatar brianteeman brianteeman - edited - 2 May 2019
avatar sanderpotjer
sanderpotjer - comment - 5 May 2019

I have tested this item successfully on b0290db

Thanks for the PR. Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24437.

avatar sanderpotjer sanderpotjer - test_item - 5 May 2019 - Tested successfully
avatar brianteeman brianteeman - change - 13 May 2019
Labels Added: ?
Removed: J4 Issue
avatar tonypartridge
tonypartridge - comment - 13 Jul 2019

I have tested this item successfully on f5260e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24437.

avatar tonypartridge tonypartridge - test_item - 13 Jul 2019 - Tested successfully
avatar Quy Quy - change - 13 Jul 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 13 Jul 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24437.

avatar brianteeman brianteeman - change - 15 Jul 2019
Labels Added: ? ?
Removed: ?
avatar wilsonge wilsonge - change - 15 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-15 08:03:03
Closed_By wilsonge
avatar wilsonge wilsonge - close - 15 Jul 2019
avatar wilsonge wilsonge - merge - 15 Jul 2019
avatar wilsonge
wilsonge - comment - 15 Jul 2019

Thanks!

avatar brianteeman
brianteeman - comment - 15 Jul 2019

Thanks

Add a Comment

Login with GitHub to post a comment